[pkg/datadog] add IgnoreMissingDatadogFields config flag for consumpt… #40226
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ion by datadog-agent connector
github-actions
bot
requested review from
ankitpatel96,
dineshg13,
jade-guiton-dd,
liustanley and
mackjmr
mx-psi
approved these changes
May 22, 2025
songy23
reviewed
May 22, 2025
Member
This already throwed an error before (just the generic "unknown key" error). I don't think the error message changing warrants a changelog |
songy23
approved these changes
May 23, 2025
Member
|
The error message is different than before, but I think that's fine if this is not intended to be used in -contrib. |
dragonlord93
pushed a commit
to dragonlord93/opentelemetry-collector-contrib
that referenced
this pull request
May 23, 2025
open-telemetry#40226) …ion by datadog-agent connector <!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> #### Description IgnoreMissingDatadogFields is needed in datadog-agent fork of datadogconnector. In `opentelemetry-collector-contrib`, for now, using this flag will throw an error. In an upcoming datadog-agent PR, we will use this flag to control datadogconnector logic in datadog-agent's `stats.OTLPTracesToConcentratorInputsWithObfuscation`. Once that is merged, a follow up PR in `opentelemetry-collector-contrib` will bump the datadog-agent version and enable these changes, at which point we'll allow IgnoreMissingDatadogFields to be set. <!-- Issue number (e.g. open-telemetry#1234) or full URL to issue, if applicable. --> #### Link to tracking issue Fixes <!--Describe what testing was performed and which tests were added.--> #### Testing <!--Describe the documentation added.--> #### Documentation <!--Please delete paragraphs that you did not use before submitting.-->
dd-jasminesun
pushed a commit
to DataDog/opentelemetry-collector-contrib
that referenced
this pull request
Jun 23, 2025
open-telemetry#40226) …ion by datadog-agent connector <!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> #### Description IgnoreMissingDatadogFields is needed in datadog-agent fork of datadogconnector. In `opentelemetry-collector-contrib`, for now, using this flag will throw an error. In an upcoming datadog-agent PR, we will use this flag to control datadogconnector logic in datadog-agent's `stats.OTLPTracesToConcentratorInputsWithObfuscation`. Once that is merged, a follow up PR in `opentelemetry-collector-contrib` will bump the datadog-agent version and enable these changes, at which point we'll allow IgnoreMissingDatadogFields to be set. <!-- Issue number (e.g. #1234) or full URL to issue, if applicable. --> #### Link to tracking issue Fixes <!--Describe what testing was performed and which tests were added.--> #### Testing <!--Describe the documentation added.--> #### Documentation <!--Please delete paragraphs that you did not use before submitting.-->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ion by datadog-agent connector
Description
IgnoreMissingDatadogFields is needed in datadog-agent fork of datadogconnector. In
opentelemetry-collector-contrib, for now, using this flag will throw an error. In an upcoming datadog-agent PR, we will use this flag to control datadogconnector logic in datadog-agent'sstats.OTLPTracesToConcentratorInputsWithObfuscation. Once that is merged, a follow up PR inopentelemetry-collector-contribwill bump the datadog-agent version and enable these changes, at which point we'll allow IgnoreMissingDatadogFields to be set.Link to tracking issue
Fixes
Testing
Documentation