-
Couldn't load subscription status.
- Fork 3.1k
[processor/transform] Add support for profiles #39974
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[processor/transform] Add support for profiles #39974
Conversation
8df3ef4 to
5f8bf23
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks reasonable to me as a first scaffolding, but I am not a codeowner for the transform processor so one of them should take a look
5f8bf23 to
95ee2fc
Compare
95ee2fc to
6f391f3
Compare
|
sorry, please address the conflict. |
@atoulme Done |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm still running a few tests but overall it looks great! Thanks for working on that.
|
Hi @rockdaboot, could you please address the conflicts? Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, could you please resolve the Go mod conflicts? Thanks!
|
I will merge this once you address the conflicts (sorry, I needed to update dependencies because of the release) |
@mx-psi Thanks, done. |
…tAttribute() (open-telemetry#41205) #### Description After the recent changes in pprofile, `Attribute.Transform()` needs to make use of `pprofile.PutAttribute()` instead of directly manipulating data structures. This change is split out of open-telemetry#39974.
#### Description PR for profiles support in the transform processor. It's a split-out from open-telemetry#39036 and contains only basic functionality, that makes this PR independent from open-telemetry#39681, open-telemetry#39416 and open-telemetry/opentelemetry-collector#12798. For this, several tests were commented out. The reason for this PR is the hope to get it merged so that users and developers can start experimenting with profiles functionality in the transformprocessor. Attributes can't currently can't be used with profiles (due to the above mentioned unmerged PRs). #### Link to tracking issue Fixes open-telemetry#39009 --------- Co-authored-by: Edmo Vamerlatti Costa <[email protected]> Co-authored-by: Tyler Helmuth <[email protected]>
Description
PR for profiles support in the transform processor.
It's a split-out from #39036 and contains only basic functionality, that makes this PR independent from #39681, #39416 and open-telemetry/opentelemetry-collector#12798.
For this, several tests were commented out.
The reason for this PR is the hope to get it merged so that users and developers can start experimenting with profiles functionality in the transformprocessor.
Attributes can't currently can't be used with profiles (due to the above mentioned unmerged PRs).
Link to tracking issue
Fixes #39009