Skip to content

Conversation

@rockdaboot
Copy link
Contributor

Description

PR for profiles support in the transform processor.
It's a split-out from #39036 and contains only basic functionality, that makes this PR independent from #39681, #39416 and open-telemetry/opentelemetry-collector#12798.
For this, several tests were commented out.

The reason for this PR is the hope to get it merged so that users and developers can start experimenting with profiles functionality in the transformprocessor.

Attributes can't currently can't be used with profiles (due to the above mentioned unmerged PRs).

Link to tracking issue

Fixes #39009

Copy link
Member

@mx-psi mx-psi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks reasonable to me as a first scaffolding, but I am not a codeowner for the transform processor so one of them should take a look

@rockdaboot rockdaboot force-pushed the transformprocessor-profiles-basic branch from 5f8bf23 to 95ee2fc Compare May 20, 2025 08:24
@rockdaboot rockdaboot force-pushed the transformprocessor-profiles-basic branch from 95ee2fc to 6f391f3 Compare May 21, 2025 10:32
@rockdaboot rockdaboot marked this pull request as ready for review May 21, 2025 10:33
@rockdaboot rockdaboot requested a review from a team as a code owner May 21, 2025 10:33
@atoulme
Copy link
Contributor

atoulme commented May 29, 2025

sorry, please address the conflict.

@rockdaboot
Copy link
Contributor Author

sorry, please address the conflict.

@atoulme Done

Copy link
Contributor

@edmocosta edmocosta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm still running a few tests but overall it looks great! Thanks for working on that.

@edmocosta
Copy link
Contributor

Hi @rockdaboot, could you please address the conflicts? Thanks!

TylerHelmuth pushed a commit that referenced this pull request Jul 9, 2025
…tAttribute() (#41205)

#### Description
After the recent changes in pprofile, `Attribute.Transform()` needs to
make use of `pprofile.PutAttribute()` instead of directly manipulating
data structures.

This change is split out of
#39974.
Copy link
Contributor

@edmocosta edmocosta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, could you please resolve the Go mod conflicts? Thanks!

@mx-psi
Copy link
Member

mx-psi commented Jul 14, 2025

I will merge this once you address the conflicts (sorry, I needed to update dependencies because of the release)

@rockdaboot
Copy link
Contributor Author

I will merge this once you address the conflicts (sorry, I needed to update dependencies because of the release)

@mx-psi Thanks, done.

@mx-psi mx-psi merged commit a69efa1 into open-telemetry:main Jul 14, 2025
177 checks passed
@github-actions github-actions bot added this to the next release milestone Jul 14, 2025
Dylan-M pushed a commit to Dylan-M/opentelemetry-collector-contrib that referenced this pull request Aug 5, 2025
…tAttribute() (open-telemetry#41205)

#### Description
After the recent changes in pprofile, `Attribute.Transform()` needs to
make use of `pprofile.PutAttribute()` instead of directly manipulating
data structures.

This change is split out of
open-telemetry#39974.
Dylan-M pushed a commit to Dylan-M/opentelemetry-collector-contrib that referenced this pull request Aug 5, 2025
#### Description
PR for profiles support in the transform processor.
It's a split-out from open-telemetry#39036 and contains only basic functionality, that
makes this PR independent from open-telemetry#39681, open-telemetry#39416 and
open-telemetry/opentelemetry-collector#12798.
For this, several tests were commented out.

The reason for this PR is the hope to get it merged so that users and
developers can start experimenting with profiles functionality in the
transformprocessor.

Attributes can't currently can't be used with profiles (due to the above
mentioned unmerged PRs).

#### Link to tracking issue
Fixes open-telemetry#39009

---------

Co-authored-by: Edmo Vamerlatti Costa <[email protected]>
Co-authored-by: Tyler Helmuth <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[processor/transform] Add initial support for profiles signal

7 participants