Skip to content

Conversation

dloucasfx
Copy link
Contributor

@dloucasfx dloucasfx commented Apr 17, 2025

Description

-eks- substring exists on all eks releases from what we have seen and I also verified by checking the repo https://github.com/aws/eks-distro/tree/main
This PR changes the EKS logic to check the cluster version and check if it contains the substring _eks_ to flag the cluster as EKS.
Unit tests are updated and code cleaned up.

Link to tracking issue

Fixes: #39479

Testing

Unit test

2025-04-18T15:44:02.285Z	info	internal/resourcedetection.go:188	detected resource information	{"resource": {"cloud.account.id":"906383545488","cloud.availability_zone":"us-west-2a","cloud.platform":"aws_eks","cloud.provider":"aws","cloud.region":"us-west-2","host.id":"i-091f2d176accf9126","host.image.id":"ami-05dbe843e7dc0237c","host.name":"ip-192-168-103-137.us-west-2.compute.internal","host.type":"c6a.large","k8s.cluster.name":"OTL-UI-Cluster","os.type":"linux"}}

@dloucasfx dloucasfx requested review from dashpole and a team as code owners April 17, 2025 23:08
@github-actions github-actions bot added the processor/resourcedetection Resource detection processor label Apr 17, 2025
@github-actions github-actions bot requested a review from Aneurysm9 April 17, 2025 23:08
@dloucasfx dloucasfx force-pushed the ResourceDetectionEKS branch from 4160f82 to 02aeb3c Compare April 17, 2025 23:12
@dloucasfx dloucasfx changed the title Use cluster version for EKS identifier [processor/resourcedetection] Use cluster version for EKS identifier Apr 17, 2025
@atoulme atoulme merged commit 13537de into open-telemetry:main Apr 24, 2025
182 checks passed
@github-actions github-actions bot added this to the next release milestone Apr 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[resourcedetection] EKS detector fails identifying EKS cluster when the configmap aws_auth is missing (ex: EKS Auto Mode)
6 participants