-
Notifications
You must be signed in to change notification settings - Fork 3k
[exporter/awsxrayexporter] update to aws-sdk-go-v2 #39244
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
9ccfac3
to
ac7d295
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for this contribution, LGTM. Going to ask code owners to review as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
left a few comments with some small questions, thanks for doing this work
a06b687
to
83f1b25
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for this work
Please address conflicts? |
Signed-off-by: Michael Shen <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks from aws xray
) <!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> #### Description aws-sdk-go is being [deprecated on July 31, 2025](https://aws.amazon.com/blogs/developer/announcing-end-of-support-for-aws-sdk-for-go-v1-on-july-31-2025/). This PR updates `exporter/awsxrayexporter` and associated dependencies in `internal/aws/xray` to aws-sdk-go-v2. <!-- Issue number (e.g. open-telemetry#1234) or full URL to issue, if applicable. --> #### Link to tracking issue Fixes open-telemetry#37726 <!--Describe what testing was performed and which tests were added.--> #### Testing I converted the existing unit tests to aws-sdk-go-v2 as well, keeping the original intent of the tests. Signed-off-by: Michael Shen <[email protected]>
) <!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> #### Description aws-sdk-go is being [deprecated on July 31, 2025](https://aws.amazon.com/blogs/developer/announcing-end-of-support-for-aws-sdk-for-go-v1-on-july-31-2025/). This PR updates `exporter/awsxrayexporter` and associated dependencies in `internal/aws/xray` to aws-sdk-go-v2. <!-- Issue number (e.g. open-telemetry#1234) or full URL to issue, if applicable. --> #### Link to tracking issue Fixes open-telemetry#37726 <!--Describe what testing was performed and which tests were added.--> #### Testing I converted the existing unit tests to aws-sdk-go-v2 as well, keeping the original intent of the tests. Signed-off-by: Michael Shen <[email protected]>
Description
aws-sdk-go is being deprecated on July 31, 2025. This PR updates
exporter/awsxrayexporter
and associated dependencies ininternal/aws/xray
to aws-sdk-go-v2.Link to tracking issue
Fixes #37726
Testing
I converted the existing unit tests to aws-sdk-go-v2 as well, keeping the original intent of the tests.