Skip to content

Conversation

mjlshen
Copy link
Contributor

@mjlshen mjlshen commented Apr 8, 2025

Description

aws-sdk-go is being deprecated on July 31, 2025. This PR updates exporter/awsxrayexporter and associated dependencies in internal/aws/xray to aws-sdk-go-v2.

Link to tracking issue

Fixes #37726

Testing

I converted the existing unit tests to aws-sdk-go-v2 as well, keeping the original intent of the tests.

@mjlshen mjlshen force-pushed the 37726 branch 2 times, most recently from 9ccfac3 to ac7d295 Compare April 8, 2025 16:28
@atoulme atoulme added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Apr 8, 2025
Copy link
Contributor

@atoulme atoulme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this contribution, LGTM. Going to ask code owners to review as well.

Copy link
Contributor

@jackgopack4 jackgopack4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

left a few comments with some small questions, thanks for doing this work

Copy link
Contributor

@jackgopack4 jackgopack4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for this work

@atoulme
Copy link
Contributor

atoulme commented Apr 29, 2025

Please address conflicts?

Copy link
Member

@mxiamxia mxiamxia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks from aws xray

@atoulme atoulme merged commit 3ebd0dd into open-telemetry:main May 1, 2025
173 checks passed
@github-actions github-actions bot added this to the next release milestone May 1, 2025
@mjlshen mjlshen deleted the 37726 branch May 1, 2025 14:26
vincentfree pushed a commit to ing-bank/opentelemetry-collector-contrib that referenced this pull request May 6, 2025
)

<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue.
Ex. Adding a feature - Explain what this achieves.-->
#### Description
aws-sdk-go is being [deprecated on July 31,
2025](https://aws.amazon.com/blogs/developer/announcing-end-of-support-for-aws-sdk-for-go-v1-on-july-31-2025/).
This PR updates `exporter/awsxrayexporter` and associated dependencies
in `internal/aws/xray` to aws-sdk-go-v2.

<!-- Issue number (e.g. open-telemetry#1234) or full URL to issue, if applicable. -->
#### Link to tracking issue
Fixes open-telemetry#37726 

<!--Describe what testing was performed and which tests were added.-->
#### Testing
I converted the existing unit tests to aws-sdk-go-v2 as well, keeping
the original intent of the tests.

Signed-off-by: Michael Shen <[email protected]>
dragonlord93 pushed a commit to dragonlord93/opentelemetry-collector-contrib that referenced this pull request May 23, 2025
)

<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue.
Ex. Adding a feature - Explain what this achieves.-->
#### Description
aws-sdk-go is being [deprecated on July 31,
2025](https://aws.amazon.com/blogs/developer/announcing-end-of-support-for-aws-sdk-for-go-v1-on-july-31-2025/).
This PR updates `exporter/awsxrayexporter` and associated dependencies
in `internal/aws/xray` to aws-sdk-go-v2.

<!-- Issue number (e.g. open-telemetry#1234) or full URL to issue, if applicable. -->
#### Link to tracking issue
Fixes open-telemetry#37726 

<!--Describe what testing was performed and which tests were added.-->
#### Testing
I converted the existing unit tests to aws-sdk-go-v2 as well, keeping
the original intent of the tests.

Signed-off-by: Michael Shen <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[exporter/awsxray] migrate to AWS v2 SDK
5 participants