Skip to content

Conversation

juanhotencoding
Copy link
Contributor

@juanhotencoding juanhotencoding commented Mar 27, 2025

…eceiver

Description

Add splunk.indexer.rollingrestart.status to splunkenterprisereceiver

Link to tracking issue

Fixes

Testing

Documentation

@juanhotencoding juanhotencoding requested review from MovieStoreGuy and a team as code owners March 27, 2025 19:06
Copy link

linux-foundation-easycla bot commented Mar 27, 2025

CLA Signed

The committers listed above are authorized under a signed CLA.

@juanhotencoding juanhotencoding changed the title Add splunk.indexer.rolling.restart.status metric to splunkenterpriser… [receiver/splunkenterprisereceiver] Add splunk.indexer.rollingrestart.status metric Mar 27, 2025
…ctor-contrib into add-splunk-rolling-restart-metric
@atoulme
Copy link
Contributor

atoulme commented Apr 14, 2025

Please address conflicts and CI failures.

@atoulme atoulme marked this pull request as draft April 14, 2025 00:35
@juanhotencoding juanhotencoding force-pushed the add-splunk-rolling-restart-metric branch from 6af8dea to f9909c5 Compare April 14, 2025 20:14
@atoulme atoulme removed the ready to merge Code review completed; ready to merge by maintainers label May 2, 2025
@atoulme
Copy link
Contributor

atoulme commented May 2, 2025

Sorry, CI fails, please fix and mark ready for review again:

Error: /home/runner/work/opentelemetry-collector-contrib/opentelemetry-collector-contrib/receiver/splunkenterprisereceiver/scraper.go:109:5: cannot use s.scrapeIndexerClusterManagerStatus (value of type func(ctx context.Context, now pcommon.Timestamp, errs chan error)) as func(context.Context, pcommon.Timestamp, infoDict, chan error) value in array or slice literal
Error: /home/runner/work/opentelemetry-collector-contrib/opentelemetry-collector-contrib/receiver/splunkenterprisereceiver/scraper.go:2077:46: cannot use ctx (variable of type context.Context) as string value in argument to s.splunkClient.createAPIRequest

@atoulme atoulme marked this pull request as draft May 2, 2025 06:35
@juanhotencoding juanhotencoding marked this pull request as ready for review May 2, 2025 21:31
@atoulme atoulme added the ready to merge Code review completed; ready to merge by maintainers label May 8, 2025
@atoulme atoulme merged commit 4ab2d95 into open-telemetry:main May 8, 2025
181 checks passed
@github-actions github-actions bot added this to the next release milestone May 8, 2025
dragonlord93 pushed a commit to dragonlord93/opentelemetry-collector-contrib that referenced this pull request May 23, 2025
….status metric (open-telemetry#39023)

…eceiver

<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue.
Ex. Adding a feature - Explain what this achieves.-->
#### Description
Add `splunk.indexer.rollingrestart.status` to splunkenterprisereceiver

<!-- Issue number (e.g. open-telemetry#1234) or full URL to issue, if applicable. -->
#### Link to tracking issue
Fixes

<!--Describe what testing was performed and which tests were added.-->
#### Testing

<!--Describe the documentation added.-->
#### Documentation

<!--Please delete paragraphs that you did not use before submitting.-->

---------

Co-authored-by: Antoine Toulme <[email protected]>
dd-jasminesun pushed a commit to DataDog/opentelemetry-collector-contrib that referenced this pull request Jun 23, 2025
….status metric (open-telemetry#39023)

…eceiver

<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue.
Ex. Adding a feature - Explain what this achieves.-->
#### Description
Add `splunk.indexer.rollingrestart.status` to splunkenterprisereceiver

<!-- Issue number (e.g. #1234) or full URL to issue, if applicable. -->
#### Link to tracking issue
Fixes

<!--Describe what testing was performed and which tests were added.-->
#### Testing

<!--Describe the documentation added.-->
#### Documentation

<!--Please delete paragraphs that you did not use before submitting.-->

---------

Co-authored-by: Antoine Toulme <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to merge Code review completed; ready to merge by maintainers receiver/splunkenterprise
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants