elasticsearchexporter: Introduce LRU cache for profiles #38606
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmathieu
force-pushed
the
profiles-cache
branch
from
f9b1f51 to
0d7d076
Compare
dmathieu
force-pushed
the
profiles-cache
branch
from
f772262 to
e663670
Compare
rockdaboot
reviewed
Mar 14, 2025
|
Maybe we can merge #38577 before this PR, as it adds two more items to |
|
Let's do yours first. |
rockdaboot
reviewed
Mar 17, 2025
atoulme
pushed a commit
that referenced
this pull request
Mar 25, 2025
…der (#38732) <!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> #### Description For #38606, we want to be able to store state within the otel encoder. We can't do that, as we encoder is root methods, not within a struct. So this PR changes that behavior to keep encoders in memory, so they can introduce shared state such as cache.
dmathieu
force-pushed
the
profiles-cache
branch
3 times, most recently
from
f6fb14e to
1a972e1
Compare
dmathieu
force-pushed
the
profiles-cache
branch
from
1a972e1 to
2cb32a0
Compare
|
This is ready for review again. |
exporter/elasticsearchexporter/internal/serializer/otelserializer/profile.go
Show resolved
Hide resolved
carsonip
approved these changes
Apr 14, 2025
rockdaboot
reviewed
Apr 14, 2025
exporter/elasticsearchexporter/internal/serializer/otelserializer/profile.go
Show resolved
Hide resolved
rockdaboot
reviewed
Apr 14, 2025
exporter/elasticsearchexporter/internal/serializer/otelserializer/profile_test.go
Outdated
Show resolved
Hide resolved
rockdaboot
approved these changes
Apr 15, 2025
carsonip
approved these changes
Apr 15, 2025
crobert-1
reviewed
Apr 15, 2025
rockdaboot
reviewed
Apr 16, 2025
|
Hopefully #39452 will fix the CI. |
crobert-1
approved these changes
Apr 16, 2025
crobert-1
added
ready to merge
akshays-19
pushed a commit
to akshays-19/opentelemetry-collector-contrib
that referenced
this pull request
Apr 23, 2025
…ry#38606) <!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> #### Description This introduces an LRU cache for profiles, so we don't overwhelm Elasticsearch with duplicate documents. --------- Co-authored-by: Tim Rühsen <[email protected]> Co-authored-by: Carson Ip <[email protected]>
Fiery-Fenix
pushed a commit
to Fiery-Fenix/opentelemetry-collector-contrib
that referenced
this pull request
Apr 24, 2025
…der (open-telemetry#38732) <!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> #### Description For open-telemetry#38606, we want to be able to store state within the otel encoder. We can't do that, as we encoder is root methods, not within a struct. So this PR changes that behavior to keep encoders in memory, so they can introduce shared state such as cache.
Fiery-Fenix
pushed a commit
to Fiery-Fenix/opentelemetry-collector-contrib
that referenced
this pull request
Apr 24, 2025
…ry#38606) <!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> #### Description This introduces an LRU cache for profiles, so we don't overwhelm Elasticsearch with duplicate documents. --------- Co-authored-by: Tim Rühsen <[email protected]> Co-authored-by: Carson Ip <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This introduces an LRU cache for profiles, so we don't overwhelm Elasticsearch with duplicate documents.