fix(datadogreceiver): set AppVersion on payload so it propagates correctly #30225
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
|
hi @boostchicken @gouthamve @jpkrohling @MovieStoreGuy - as CODEOWNERS of the DD receiver, could I get some 👀 on this? |
jpkrohling
approved these changes
Feb 1, 2024
cparkins
pushed a commit
to AmadeusITGroup/opentelemetry-collector-contrib
that referenced
this pull request
Feb 1, 2024
…ectly (open-telemetry#30225) **Description:** <Describe what has changed.> <!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> This PR sets the AppVersion property for the default fallthrough case if it exists on any spans in the request. This allows it to properly propagate through to Datadog. Currently, if using a library such as datadog/dd-trace-dotnet , the datadog service version property (dd_version) does not propagate through to datadog at all. The bug that this fixes is that the Datadog version resource attribute is currently not flowing through. **Link to tracking Issue:** <Issue number if applicable> Closes open-telemetry#30526 **Testing:** <Describe what testing was performed and which tests were added.> Local testing using delve to confirm expected behavior, added existing version tag to tests. Deployed patch internally on OpenTelemetry collector and observed desired behavior. **Documentation:** <Describe the documentation added.>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR sets the AppVersion property for the default fallthrough case if it exists on any spans in the request. This allows it to properly propagate through to Datadog. Currently, if using a library such as datadog/dd-trace-dotnet , the datadog service version property (dd_version) does not propagate through to datadog at all.
The bug that this fixes is that the Datadog version resource attribute is currently not flowing through.
Link to tracking Issue:
Closes #30526
Testing:
Local testing using delve to confirm expected behavior, added existing version tag to tests. Deployed patch internally on OpenTelemetry collector and observed desired behavior.
Documentation: