wrong comparison func implement in translator/prometheusremotewrite #35741
Description
Component(s)
pkg/translator/prometheusremotewrite
What happened?
Description
in func isSameMetric, ts is compare with itself
func isSameMetric(ts *prompb.TimeSeries, lbls []prompb.Label) bool {
if len(ts.Labels) != len(lbls) {
return false
}
for i, l := range ts.Labels {
if l.Name != ts.Labels[i].Name || l.Value != ts.Labels[i].Value {
return false
}
}
return true
}revise
func isSameMetric(ts *prompb.TimeSeries, lbls []prompb.Label) bool {
if len(ts.Labels) != len(lbls) {
return false
}
for i, l := range ts.Labels {
if l.Name != lbls[i].Name || l.Value != lbls[i].Value {
return false
}
}
return true
}Collector version
master
Environment information
No response
OpenTelemetry Collector configuration
No response
Log output
No response
Additional context
No response