Skip to content

Conversation

@joshdavham
Copy link
Member

Will probably close #149

With the recent update of ty, our type-check.yml gh workflow is now failing. This was due to to one error in get_card_retrievability().

Additionally, there were two new warnings associated with the torch-related code in the scheduler module. I've suppressed those since I'm not really sure how to handle that given that torch is conditionally imported.

Lmk if you have any questions 👍

@codecov
Copy link

codecov bot commented Nov 8, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.62%. Comparing base (81765cf) to head (8053894).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #150   +/-   ##
=======================================
  Coverage   98.62%   98.62%           
=======================================
  Files           7        7           
  Lines         653      653           
=======================================
  Hits          644      644           
  Misses          9        9           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@joshdavham joshdavham marked this pull request as ready for review November 8, 2025 03:43
@joshdavham joshdavham added this pull request to the merge queue Nov 8, 2025
Merged via the queue into main with commit dd4a357 Nov 8, 2025
25 checks passed
@joshdavham joshdavham deleted the fix-ty branch November 8, 2025 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants