Skip to content

Revert alerts, refactor docker image builds #1066

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Aug 12, 2025
Merged

Conversation

aaronchongth
Copy link
Member

@aaronchongth aaronchongth commented Aug 8, 2025

What's new

Supercedes #1060

  • add alerts implementation back
  • fix ci builds to no longer build messages from source
  • update CI for different ros distros to check out to the respective branch
  • bump codecov and other misc fixes to ci

Self-checks

  • I'm familiar with and follow this Typescript guideline
  • I added unit-tests for new components
  • I tried testing edge cases
  • I tested the behavior of the components that interact with the backend, with an e2e test

Discussion

…ing, use branch for builds

Signed-off-by: Aaron Chong <[email protected]>
@mxgrey mxgrey added this to PMC Board Aug 8, 2025
@github-project-automation github-project-automation bot moved this to Inbox in PMC Board Aug 8, 2025
@aaronchongth aaronchongth mentioned this pull request Aug 8, 2025
4 tasks
Copy link

codecov bot commented Aug 8, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (main@7aa2653). Learn more about missing BASE report.
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1066   +/-   ##
=======================================
  Coverage        ?   70.00%           
=======================================
  Files           ?      288           
  Lines           ?    14173           
  Branches        ?     1136           
=======================================
  Hits            ?     9922           
  Misses          ?     4227           
  Partials        ?       24           
Flag Coverage Δ
api-server 79.39% <100.00%> (?)
rmf-dashboard-framework 67.41% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@aaronchongth aaronchongth requested a review from koonpeng August 8, 2025 09:27
@aaronchongth aaronchongth moved this from Inbox to In Review in PMC Board Aug 12, 2025
@aaronchongth aaronchongth merged commit 22fc6c2 into main Aug 12, 2025
9 checks passed
@aaronchongth aaronchongth deleted the prep-for-kilted-2 branch August 12, 2025 01:42
@github-project-automation github-project-automation bot moved this from In Review to Done in PMC Board Aug 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants