[Fix] Ensure from_cfg of Runner have the same defaults values as its __init__ #1368
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hen instantiated from a configuration file and when instantiated directly.
yinaoxiong
requested review from
zhouzaida,
RangiLyu and
HAOCHENYE
as code owners
|
|
zhouzaida
reviewed
Sep 27, 2023
zhouzaida
reviewed
Sep 27, 2023
zhouzaida
approved these changes
Sep 27, 2023
zhouzaida
changed the title
|
Hi @yinaoxiong , thanks for your contribution. This PR will be merged after passing the CI. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.
Motivation
When I followed the 15-minute tutorial in MMENGINE to write the configuration file, I found that I was missing the setting of env_cfg, but directly instantiating the Runner does not require setting env_cfg. Ensuring that the default parameters for a runner instantiated from a configuration file and instantiated directly are the same will be less confusing.
Modification
Add default parameters consistent with the Runner class to the env_cfg of the configuration file.