Skip to content

Conversation

@Chan-Sun
Copy link
Contributor

@Chan-Sun Chan-Sun commented Dec 5, 2022

Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.

Motivation

import Config has been changed in openmmlab-2.0, update the import code in the ./tools/model_converters

Modification

Replace from mmcv import Config, DictAction with from mmengine import Config, DictAction

Two files are changed, including ./tools/model_converters/upgrade_ssd_version.py and ./tools/model_converters/upgrade_model_version.py

BC-breaking (Optional)

Does the modification introduce changes that break the backward-compatibility of the downstream repos?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.

Use cases (Optional)

If this PR introduces a new feature, it is better to list some use cases here, and update the documentation.

Checklist

  1. Pre-commit or other linting tools are used to fix the potential lint issues.
  2. The modification is covered by complete unit tests. If not, please add more unit test to ensure the correctness.
  3. If the modification has potential influence on downstream projects, this PR should be tested with downstream projects, like MMDet or MMCls.
  4. The documentation has been modified accordingly, like docstring or example tutorials.

@ZwwWayne ZwwWayne added this to the 3.0.0rc5 milestone Dec 6, 2022
@ZwwWayne
Copy link
Collaborator

ZwwWayne commented Dec 6, 2022

Hi @Chan-Sun ,
Thanks for your kind contribution. Would you like to fix the lint issue so that we could merge this PR?
The details can be found by clicking the item of lint check as shown below
image

@ZwwWayne ZwwWayne merged commit 595a20d into open-mmlab:dev-3.x Dec 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants