Skip to content

feat: adjust to flagd metadata toggle #287

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

leakonvalinka
Copy link
Member

This PR

  • adjusts the implementation to handle both paths that the disable-sync-metadata toggle introduces

Related Issues

closes #278
relates open-feature/flagd#1584

Copy link

codecov bot commented Jul 30, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 95.30%. Comparing base (bfc0070) to head (a5b91d1).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #287      +/-   ##
==========================================
- Coverage   98.03%   95.30%   -2.74%     
==========================================
  Files           3       15      +12     
  Lines          51      852     +801     
==========================================
+ Hits           50      812     +762     
- Misses          1       40      +39     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Signed-off-by: Konvalinka <[email protected]>
@leakonvalinka leakonvalinka force-pushed the feat/adjust-to-metadata-toggle branch from e2feb84 to 6d6ebb8 Compare July 30, 2025 13:51
@leakonvalinka leakonvalinka marked this pull request as ready for review August 4, 2025 12:26
@leakonvalinka leakonvalinka requested review from a team as code owners August 4, 2025 12:26
Signed-off-by: Konvalinka <[email protected]>
Signed-off-by: Konvalinka <[email protected]>
Signed-off-by: Konvalinka <[email protected]>
@aepfli aepfli merged commit 6ac014d into open-feature:main Aug 6, 2025
12 of 13 checks passed
@aepfli aepfli deleted the feat/adjust-to-metadata-toggle branch August 6, 2025 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[flagd] use sync_context field instead of GetMetadata
3 participants