Skip to content

fix: API server warning for empty imagePullSecrets #774

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 14, 2025

Conversation

Y0sh1dk
Copy link
Contributor

@Y0sh1dk Y0sh1dk commented Jul 12, 2025

This PR

Fixes API server warning for empty imagePullSecrets

INFO    KubeAPIWarningLogger    spec.template.spec.imagePullSecrets[0].name: invalid empty name ""

Previously FlagdConfiguration.ImagePullSecrets would be [""] when no --image-pull-secrets is supplied, this results in a invalid Deployment resource when a Flagd resource is applied. After this change FlagdConfiguration.ImagePullSecrets results in [] which ensures the generated Deployments don't throw API server warnings.

Signed-off-by: Yosiah de Koeyer <[email protected]>
@Y0sh1dk Y0sh1dk requested a review from a team July 12, 2025 07:05
Copy link
Member

@lukas-reining lukas-reining left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @Y0sh1dk!
This looks good to me :)

Copy link

codecov bot commented Jul 13, 2025

Codecov Report

Attention: Patch coverage is 0% with 8 lines in your changes missing coverage. Please review.

Project coverage is 71.36%. Comparing base (499661e) to head (bf1ad3c).
Report is 68 commits behind head on main.

Files with missing lines Patch % Lines
cmd/main.go 0.00% 8 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main     #774       +/-   ##
===========================================
- Coverage   86.51%   71.36%   -15.15%     
===========================================
  Files          19       30       +11     
  Lines        1587     2305      +718     
===========================================
+ Hits         1373     1645      +272     
- Misses        173      612      +439     
- Partials       41       48        +7     
Files with missing lines Coverage Δ
cmd/main.go 0.00% <0.00%> (ø)

... and 10 files with indirect coverage changes

Flag Coverage Δ
unit-tests 71.36% <0.00%> (∅)

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@beeme1mr beeme1mr merged commit 6f7152c into open-feature:main Jul 14, 2025
17 of 19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants