feat: add gateway api #725
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukas-reining
requested review from
beeme1mr,
bacherfl,
toddbaert,
odubajDT and
a team
lukas-reining
force-pushed
the
feat/add-gateway-api
branch
6 times, most recently
from
d94db05 to
0714181
Compare
beeme1mr
approved these changes
Jan 13, 2025
Signed-off-by: Lukas Reining <[email protected]>
lukas-reining
force-pushed
the
feat/add-gateway-api
branch
from
0714181 to
7249b7e
Compare
Signed-off-by: Lukas Reining <[email protected]>
lukas-reining
force-pushed
the
feat/add-gateway-api
branch
from
bb31a2a to
81203f7
Compare
This was referenced Jan 13, 2025
Merged
|
This is really cool. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR
Adds Gateway API support as described in #723, similar to the ingress support in #633.
The operator only creates an
HTTPRoutefor all endpoints instead of explicitly creating aGRPCRoutefor the GRPCendpoints, because we are using GRPC Gateway to enable HTTP+JSON for the GRPC endpoints.
This means that these endpoint not only support GRPC, but also plain HTTP. Because of this,
GRPCRoutedoes not workwell for these endpoints.
I decided to not make the paths/methods configurable, while they are for ingress, as they can not be adjusted in flagd anyways.
The Go version had to be updated as the gateway api package is not working with Go 1.21. Due to this I also had to update the chainsaw version.
Related Issues
Fixes #723