Skip to content

Conversation

leakonvalinka
Copy link
Member

@leakonvalinka leakonvalinka commented Jul 23, 2025

This PR

  • adds a toggle disable-sync-metadata for the Sync Service to disable or enable the deprecated getMetadata request

Related Issues

#1688 [FEATURE] Temporary Context Enrichment toggle

Copy link

netlify bot commented Jul 23, 2025

Deploy Preview for polite-licorice-3db33c canceled.

Name Link
🔨 Latest commit 191f88b
🔍 Latest deploy log https://app.netlify.com/projects/polite-licorice-3db33c/deploys/68821cc2a5e21000083db10d

Signed-off-by: Konvalinka <[email protected]>
@toddbaert
Copy link
Member

Looks like you're heading in the right direction!

There's an e2e test that needs updating because of the submodule update, and I left some text suggestions and a suggestion about using an informative error code.

@leakonvalinka leakonvalinka marked this pull request as ready for review July 24, 2025 12:14
@leakonvalinka leakonvalinka requested a review from a team July 24, 2025 12:14
@leakonvalinka leakonvalinka requested a review from a team as a code owner July 24, 2025 12:14
@dosubot dosubot bot added the size:L This PR changes 100-499 lines, ignoring generated files. label Jul 24, 2025
@leakonvalinka leakonvalinka changed the title feat: Add toggle for sync context vs. metadata feat: Add toggle for disabling getMetadata request Jul 24, 2025
@aepfli aepfli merged commit e8fd680 into open-feature:main Jul 28, 2025
18 checks passed
@github-actions github-actions bot mentioned this pull request Jul 24, 2025
toddbaert pushed a commit that referenced this pull request Jul 28, 2025
🤖 I have created a release *beep* *boop*
---


<details><summary>flagd: 0.12.9</summary>

##
[0.12.9](flagd/v0.12.8...flagd/v0.12.9)
(2025-07-28)


### ✨ New Features

* Add toggle for disabling getMetadata request
([#1693](#1693))
([e8fd680](e8fd680))
</details>

<details><summary>core: 0.12.1</summary>

##
[0.12.1](core/v0.12.0...core/v0.12.1)
(2025-07-28)


### 🧹 Chore

* add back file-delete test
([#1694](#1694))
([750aa17](750aa17))
* fix benchmark
([#1698](#1698))
([5e2d7d7](5e2d7d7))
</details>

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Signed-off-by: OpenFeature Bot <[email protected]>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size:L This PR changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants