-
Notifications
You must be signed in to change notification settings - Fork 87
feat: Add toggle for disabling getMetadata request #1693
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
aepfli
merged 5 commits into
open-feature:main
from
open-feature-forking:feat/toggle-sync-context
Jul 28, 2025
Merged
feat: Add toggle for disabling getMetadata request #1693
aepfli
merged 5 commits into
open-feature:main
from
open-feature-forking:feat/toggle-sync-context
Jul 28, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Konvalinka <[email protected]>
✅ Deploy Preview for polite-licorice-3db33c canceled.
|
Signed-off-by: Konvalinka <[email protected]>
toddbaert
reviewed
Jul 23, 2025
toddbaert
reviewed
Jul 23, 2025
toddbaert
reviewed
Jul 23, 2025
Looks like you're heading in the right direction! There's an e2e test that needs updating because of the submodule update, and I left some text suggestions and a suggestion about using an informative error code. |
Signed-off-by: Konvalinka <[email protected]>
Signed-off-by: Konvalinka <[email protected]>
aepfli
approved these changes
Jul 24, 2025
toddbaert
approved these changes
Jul 28, 2025
Merged
toddbaert
pushed a commit
that referenced
this pull request
Jul 28, 2025
🤖 I have created a release *beep* *boop* --- <details><summary>flagd: 0.12.9</summary> ## [0.12.9](flagd/v0.12.8...flagd/v0.12.9) (2025-07-28) ### ✨ New Features * Add toggle for disabling getMetadata request ([#1693](#1693)) ([e8fd680](e8fd680)) </details> <details><summary>core: 0.12.1</summary> ## [0.12.1](core/v0.12.0...core/v0.12.1) (2025-07-28) ### 🧹 Chore * add back file-delete test ([#1694](#1694)) ([750aa17](750aa17)) * fix benchmark ([#1698](#1698)) ([5e2d7d7](5e2d7d7)) </details> --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Signed-off-by: OpenFeature Bot <[email protected]> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR
disable-sync-metadata
for the Sync Service to disable or enable the deprecatedgetMetadata
requestRelated Issues
#1688 [FEATURE] Temporary Context Enrichment toggle