feat: add sync_context to SyncFlags

[bbland1]

This PR

• adds comment about GetMetadata being deprecated in future release
• implements the sync_context field to the SyncFlags of flag-sync/handler.go

Related Issues

Fixes #1635

[netlify]

✅ Deploy Preview for polite-licorice-3db33c canceled.

Name	Link
🔨 Latest commit	cdbcb82
🔍 Latest deploy log	https://app.netlify.com/projects/polite-licorice-3db33c/deploys/6865a7ae2010220008974a91

[aepfli]

Thank you, I have nothing to add to the implementation, more like how we will proceed here, so we will not create breaking changes for everyone ;) - how do we know if the data is in the payload or a separate request. but this is something we might want to discuss on the issue rather here.

[toddbaert]

Hey @bbland1 ! Sorry for the delay. I will review this early next week or possibly over the weekend.

[toddbaert]

Thank you, I have nothing to add to the implementation, more like how we will proceed here, so we will not create breaking changes for everyone ;) - how do we know if the data is in the payload or a separate request. but this is something we might want to discuss on the issue rather here.

My thinking is we just leave this as it is (with no breaking changes and both working) for a long time* and update the providers to use the new feature as soon as possible. That will minimize the chance anyone is impacted when we actually remove this feature (probably in v1).

* depending on how fast we can implement this in providers

[toddbaert]

@bbland1 great work! I tested this manually and it works as expected:

I've pushed 2 very small changes:

• go mod tidy in /core
• updated the schema submodule - I'm guessing you have this locally but didn't commit it, because it doesn't work otherwise. It can be tricky to update submodules, my method is usually to cd into it, and then checkout what I want (in this case the 0.6.4 proto release) and then commit the resultant submodule metadata change from the root directory (not the submodule dir you moved into)

[toddbaert]

I'll merge this soon unless I hear objections.

[bbland1]

I've pushed 2 very small changes:

• go mod tidy in /core
• updated the schema submodule - I'm guessing you have this locally but didn't commit it, because it doesn't work otherwise. It can be tricky to update submodules, my method is usually to cd into it, and then checkout what I want (in this case the 0.6.4 proto release) and then commit the resultant submodule metadata change from the root directory (not the submodule dir you moved into)

Happy to see it working on your end too! Yeah I updated it locally but I didn’t realize it wouldn’t push until you just said this so that makes total sense, thanks! Now I can make a note of it for the future. Nice catch on the go mod tidy in /core!