-
Notifications
You must be signed in to change notification settings - Fork 87
Description
With our recent changes in #1702, we can now use the selector
to select flags based on their flagSetId
- however, we can't explicitly select on flags WITHOUT a flagSetId
. We need to:
- decide on a way to express this in the selector/header (ie:
flagSetId=
orflagSetId=null
orflagSetId=default
) or something like this. If we usenull
ordefault
here, we must consider these special cases, so I recommendflagSetId=
to express selecting the null set. - after deciding on the above, actually implement selection on the null
flagSetId
(as currently implemented, this simply mean querying with thenilFlagSetId
constant which is internally assigned to all flags without aflagSetId
) - optionally, find an alternative way (besides using the
nilFlagSetId
mentioned above) to index flags withoutflagSetId
s.
I think we discussed the problem when introducing the flag lists. Imagine there are two flags {key: feature, set: A} and {key: feature, set: null}, when an in-process provider constructs the selector, there's no way for it to get a valid flag map with {key: feature, set: null} in the result. It will be a problem for adopting flag sets - basically without the ability to select on the null set, users have to create a "default" set for all existing flags if they need to add a flag with the same key under another set.
Originally posted by @tangenti in #1702 (comment)
Metadata
Metadata
Assignees
Labels
Type
Projects
Status