feat: relative weights in fractional, fix injected props #208
Conversation
toddbaert
force-pushed
the
feat/fractional-op-relative-weights
branch
from
506724a to
7ebf869
Compare
|
@aepfli Not sure if .NET is your thing, but since you did a few others, could you quickly skim this? |
|
|
||
| [Theory] | ||
| [MemberData(nameof(FractionalEvaluationTestData.FractionalEvaluationContext), MemberType = typeof(FractionalEvaluationTestData))] | ||
| public void EvaluateUsingRelativeWeights(string email, string flagKey, string expected) |
There was a problem hiding this comment.
we should evaluate if it makes sense to move the json tests of the java contrib sdk from https://github.com/open-feature/java-sdk-contrib/tree/main/providers/flagd/src/test/resources/fractional to the harness, and use them as test for all our implementation of the fractionals. maybe we are still missing some data, which is part of the test code, but i think this would allow us to be more stable throughout all the packages. Normally there should be a way in each of our contrib sdks to load json files and to parameterize tests in some sort of way (assumption for dotnet)
Signed-off-by: Florian Bacher <[email protected]>
Signed-off-by: Florian Bacher <[email protected]>
toddbaert
force-pushed
the
feat/fractional-op-relative-weights
branch
from
7ebf869 to
3b61919
Compare
|
I found a couple small issues with this when adding some additional e2e tests, working on some fixes. |
toddbaert
force-pushed
the
feat/fractional-op-relative-weights
branch
from
9d6d572 to
edd04f0
Compare
Signed-off-by: Todd Baert <[email protected]>
toddbaert
force-pushed
the
feat/fractional-op-relative-weights
branch
from
a8b55a0 to
132ab9d
Compare
| { | ||
| //object value; | ||
| if (from is Dictionary<string, object> dict) | ||
| if (from is IDictionary<string, object> dict) |
There was a problem hiding this comment.
This stumped me for a moment. In prod, from here implements IDictionary, but is not actually an instance of Dictionary, so this evaluated to false, resulting in no injected props. This fixes it!
toddbaert
changed the title
…e#208) Signed-off-by: Florian Bacher <[email protected]> Signed-off-by: Todd Baert <[email protected]> Co-authored-by: Todd Baert <[email protected]>
3 participants
This PR adds support for relative weights in the fractional evaluator. This new (non breaking) feature has been proposed in open-feature/flagd#1282 (The related PR to implement this in flagd is this one: open-feature/flagd#1313).
In addition to supporting relative weights instead of percentages, the weight value for a distribution item can be omitted. In this case, a default weight of
1will be applied.Leaving this in draft until the related PR in flagd has been merged