Add gunicorn with TLS as web server for mapping app #529
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
saratpoluri
force-pushed
the
feature/mapping-service
branch
from
4e6f12b to
171cf8a
Compare
MikolajKasprzak
force-pushed
the
tls-mapping-service
branch
from
4b841d8 to
4951751
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR adds TLS-enabled Gunicorn as the production web server for the mapping application, replacing the Flask development server. The changes introduce certificate management infrastructure and command-line options to switch between development and production modes.
Key Changes
- Added Gunicorn with TLS support as the default production server mode
- Implemented certificate generation and mounting for the mapping service
- Added command-line arguments to toggle between development (Flask) and production (Gunicorn + TLS) modes
Reviewed Changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| tools/certificates/Makefile | Added mapping-cert and mapping-csr targets for certificate generation |
| sample_data/docker-compose-dl-streamer-example.yml | Added mapping certificate secrets and mounted them to the mapping service |
| mapping/src/vggt_service.py | Imported app object for Gunicorn access |
| mapping/src/mapanything_service.py | Imported app object for Gunicorn access |
| mapping/src/api_service_base.py | Added Gunicorn server support with TLS, command-line argument parsing, and dual-mode operation |
| mapping/requirements_api.txt | Added gunicorn dependency |
| mapping/Dockerfile | Simplified startup script to support development/production modes via environment variables |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
ltalarcz
reviewed
Oct 31, 2025
| target: certs/scenescape-mapping.key | ||
| healthcheck: | ||
| test: ["CMD", "curl", "-I", "-s", "http://localhost:8000/health"] | ||
| test: ["CMD", "curl", "-k", "-I", "-s", "https://localhost:8000/health"] |
There was a problem hiding this comment.
Could you change also port number? 8000 is typically used for HTTP
ltalarcz
reviewed
Oct 31, 2025
Comment on lines
+339
to
+343
| parser.add_argument( | ||
| "--dev-mode", | ||
| action="store_true", | ||
| help="Run in development mode with Flask development server (default: production mode with Gunicorn + TLS)" | ||
| ) |
There was a problem hiding this comment.
Please consider removing dev-mode, I don't think we need it at all.
saratpoluri
force-pushed
the
tls-mapping-service
branch
from
4dbaaa9 to
6675050
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Description
Added gunicorn with TLS as web server for mapping app
✨ Type of Change
Select the type of change your PR introduces:
🧪 Testing Scenarios
Describe how the changes were tested and how reviewers can test them too:
✅ Checklist
Before submitting the PR, ensure the following: