✨ feat(post-processing): Add MEBin post processor from AnomalyNCD #3030

rajeshgangireddy · 2025-10-15T14:43:18Z

📝 Description

This is based on #2928
I have closed that PR and started this new one with additional changes.

✨ Changes

Select what type of change your PR is:

✅ Checklist

Before you submit your pull request, please make sure you have completed the following steps:

📚 I have made the necessary updates to the documentation (if applicable).
🧪 I have written tests that support my changes and prove that my fix is effective or my feature works (if applicable).
🏷️ My PR title follows conventional commit format.

For more information about code review checklists, see the Code Review Checklist.

…chCore, Padim, Dfkde (open-edge-platform#2913) * refactor patchcore, use list instead of cat * typo in patchcore Signed-off-by: Alfie Roddan <[email protected]> * padim model to now use cat instead of list Signed-off-by: Alfie Roddan <[email protected]> * dfm and padim update cat to list Signed-off-by: Alfie Roddan <[email protected]> * add dfkde cat to list changes Signed-off-by: Alfie Roddan <[email protected]> * change assert from memory bank to list size, fix pre-commit issues Signed-off-by: Alfie Roddan <[email protected]> --------- Signed-off-by: Alfie Roddan <[email protected]> Signed-off-by: StarPlatinum7 <[email protected]>

Signed-off-by: StarPlatinum7 <[email protected]>

…#2920) * added histogram of anomaly scores * Update src/anomalib/metrics/anomaly_score_distribution.py Co-authored-by: Samet Akcay <[email protected]> Signed-off-by: Aimira Baitieva <[email protected]> * Update anomaly_score_distribution.py * Update anomaly_score_distribution.py * Fixed pre-commit checks --------- Signed-off-by: Aimira Baitieva <[email protected]> Co-authored-by: Samet Akcay <[email protected]> Signed-off-by: StarPlatinum7 <[email protected]>

* added pg and pb metrics * fixed typos * Update __init__.py * Update __init__.py - removed duplicate * Update pg_pb.py * Fixed pre-commit checks --------- Co-authored-by: Samet Akcay <[email protected]> Co-authored-by: Rajesh Gangireddy <[email protected]> Signed-off-by: StarPlatinum7 <[email protected]>

Co-authored-by: Copilot <[email protected]> Signed-off-by: Rajesh Gangireddy <[email protected]>

Copilot

Pull Request Overview

Copilot reviewed 8 out of 8 changed files in this pull request and generated 1 comment.

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

src/anomalib/post_processing/mebin_post_processor.py

Co-authored-by: Copilot <[email protected]> Signed-off-by: Rajesh Gangireddy <[email protected]>

Copilot

Pull Request Overview

Copilot reviewed 8 out of 8 changed files in this pull request and generated 3 comments.

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

src/anomalib/metrics/threshold/mebin.py

… print statement

Copilot

Pull Request Overview

Copilot reviewed 8 out of 8 changed files in this pull request and generated 2 comments.

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

src/anomalib/metrics/threshold/mebin.py

…er clarity

rajeshgangireddy · 2025-10-15T15:04:35Z

Thanks to @StarPlatinum7 for the contribution.

rajeshgangireddy · 2025-10-15T15:05:12Z

PS : I am yet to fully test this as a post processor with an with anomalib model.

Copilot

Pull Request Overview

Copilot reviewed 8 out of 8 changed files in this pull request and generated 4 comments.

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

src/anomalib/metrics/threshold/mebin.py

src/anomalib/post_processing/mebin_post_processor.py

StarPlatinum7 · 2025-10-15T15:52:51Z

Thanks for your review！This strategy is proposed in AnomalyNCD (CVPR2025).And I have test mebin as a post processor like this:

from anomalib.models import Patchcore
from anomalib.engine import Engine
from anomalib.post_processing import MEBinPostProcessor
datamodule = MVTecAD(
    category='bottle', # category in mvtec dataset
    root = "./mvtec_anomaly_detection", # path where dataset is stored
    train_batch_size = 16,
    eval_batch_size = 16,
)
engine = Engine(
    default_root_dir = './output', # path where results are saved

)
model = Patchcore(
    post_processor=MEBinPostProcessor(
        sample_rate=4,
        min_interval_len=4,
        erode=True
    )
)
engine.train(datamodule=datamodule, model=model)

…rity

…check if implementation matches author's implementation

Copilot

Pull Request Overview

Copilot reviewed 8 out of 8 changed files in this pull request and generated 3 comments.

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

Copilot · 2025-10-21T15:10:51Z

src/anomalib/post_processing/mebin_post_processor.py

+    Example:
+        >>> from anomalib.post_processing import MEBinPostProcessor
+        >>> from anomalib.data import InferenceBatch
+        >>> import torch


Duplicate 'Example:' label on consecutive lines. Remove one of the duplicate labels.

Suggested change

Example:

>>> from anomalib.post_processing import MEBinPostProcessor

>>> from anomalib.data import InferenceBatch

>>> import torch

>>> from anomalib.post_processing import MEBinPostProcessor

>>> from anomalib.data import InferenceBatch

>>> import torch

>>> import torch

Copilot · 2025-10-21T15:10:52Z

src/anomalib/metrics/threshold/mebin.py

+        Stable Interval: A continuous threshold range in which the number of connected components remains constant,
+        and the length of the threshold range is greater than or equal to the given length threshold
+        (min_interval_len).


[nitpick] The docstring contains a 'Stable Interval' definition that appears to be part of the description rather than a separate section. Consider integrating this into the main description or using a Note/Warning block for clarity.

Suggested change

Stable Interval: A continuous threshold range in which the number of connected components remains constant,

and the length of the threshold range is greater than or equal to the given length threshold

(min_interval_len).

A "stable interval" is defined as a continuous threshold range in which the number of connected components remains constant,

and the length of the threshold range is greater than or equal to the given minimum interval length (`min_interval_len`).

Copilot · 2025-10-21T15:10:52Z

src/anomalib/metrics/threshold/mebin.py

+        (min_interval_len).
+
+        Args:
+            anomaly_num_sequence (list): Sequence of connected component counts


Type hint 'list' is not specific. Should be 'list[int]' to match the actual usage.

Suggested change

anomaly_num_sequence (list): Sequence of connected component counts

anomaly_num_sequence (list[int]): Sequence of connected component counts

alfieroddan and others added 11 commits September 8, 2025 18:32

add mebin postprocessor

ce4097b

Signed-off-by: StarPlatinum7 <[email protected]>

test mebin postprocessor

1e68949

Signed-off-by: StarPlatinum7 <[email protected]>

test mebin postprocessor

3603157

Signed-off-by: StarPlatinum7 <[email protected]>

Merge branch 'main' into feat/postprocess/add_mebin_post_processor

f873e67

Merge branch 'main' into feat/postprocess/add_mebin_post_processor

35e3d0d

✨ feat(post-processing): Make minor changes as per comments

fa69cf6

maintainer review: incorporate feedback and improvements

2f144d9

📦 docs(post-processor): revert docs for MEBIN

ab8a5af

rajeshgangireddy requested a review from samet-akcay as a code owner October 15, 2025 14:43

Copilot AI review requested due to automatic review settings October 15, 2025 14:43

rajeshgangireddy requested a review from ashwinvaidya17 as a code owner October 15, 2025 14:43

This comment was marked as outdated.

Sign in to view

Update src/anomalib/post_processing/mebin_post_processor.py

1b6e845

Co-authored-by: Copilot <[email protected]> Signed-off-by: Rajesh Gangireddy <[email protected]>

Copilot AI review requested due to automatic review settings October 15, 2025 14:44

Update src/anomalib/metrics/threshold/mebin.py

46c0ae8

Co-authored-by: Copilot <[email protected]> Signed-off-by: Rajesh Gangireddy <[email protected]>

Copilot AI reviewed Oct 15, 2025

View reviewed changes

src/anomalib/post_processing/mebin_post_processor.py Outdated Show resolved Hide resolved

Update src/anomalib/post_processing/mebin_post_processor.py

b757b27

Co-authored-by: Copilot <[email protected]> Signed-off-by: Rajesh Gangireddy <[email protected]>

Copilot AI review requested due to automatic review settings October 15, 2025 14:46

Copilot AI reviewed Oct 15, 2025

View reviewed changes

src/anomalib/metrics/threshold/mebin.py Show resolved Hide resolved

src/anomalib/metrics/threshold/mebin.py Outdated Show resolved Hide resolved

src/anomalib/metrics/threshold/mebin.py Outdated Show resolved Hide resolved

rajeshgangireddy added 2 commits October 15, 2025 16:50

🐛 fix(mebin): remove debug print statement for value range

1f29065

🐛 fix(mebin): update threshold return types to float and remove debug…

188275b

… print statement

Copilot AI review requested due to automatic review settings October 15, 2025 14:54

Copilot AI reviewed Oct 15, 2025

View reviewed changes

src/anomalib/metrics/threshold/mebin.py Show resolved Hide resolved

src/anomalib/metrics/threshold/mebin.py Show resolved Hide resolved

rajeshgangireddy mentioned this pull request Oct 15, 2025

feat(postprocess): add MEBin post-processing method #2928

Closed

15 tasks

🐛 fix(mebin): update return types in MEBin methods to tuples for bett…

bf9ecfa

…er clarity

🐛 fix(mebin): simplify max calculation for connected component counts

473c6db

Copilot AI review requested due to automatic review settings October 15, 2025 15:06

Copilot AI reviewed Oct 15, 2025

View reviewed changes

🐛 fix(mebin): update examples in MEBin and MEBinPostProcessor for cla…

b1ea898

…rity

rajeshgangireddy marked this pull request as draft October 17, 2025 09:08

🐛 fix(mebin): refactor MEBin post-processing . Works now. Need to re-…

d91e685

…check if implementation matches author's implementation

Copilot AI review requested due to automatic review settings October 21, 2025 15:10

Copilot AI reviewed Oct 21, 2025

View reviewed changes

rajeshgangireddy marked this pull request as ready for review October 23, 2025 07:41

Merge branch 'main' into mebin_changes

637eb7a

	anomaly_num_sequence (list): Sequence of connected component counts
	anomaly_num_sequence (list[int]): Sequence of connected component counts

✨ feat(post-processing): Add MEBin post processor from AnomalyNCD #3030

Are you sure you want to change the base?

✨ feat(post-processing): Add MEBin post processor from AnomalyNCD #3030

Uh oh!

Conversation

rajeshgangireddy commented Oct 15, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

📝 Description

✨ Changes

✅ Checklist

Uh oh!

This comment was marked as outdated.

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Uh oh!

Uh oh!

Uh oh!

rajeshgangireddy commented Oct 15, 2025

Uh oh!

rajeshgangireddy commented Oct 15, 2025

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

StarPlatinum7 commented Oct 15, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Uh oh!

Copilot AI Oct 21, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Oct 21, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Oct 21, 2025

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

rajeshgangireddy commented Oct 15, 2025 •

edited

Loading

StarPlatinum7 commented Oct 15, 2025 •

edited

Loading