Skip to content

Conversation

bittersweet1999
Copy link
Collaborator

Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.

Motivation

Please describe the motivation of this PR and the goal you want to achieve through this PR.

Modification

Please briefly describe what modification is made in this PR.

BC-breaking (Optional)

Does the modification introduce changes that break the backward compatibility of the downstream repositories?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.

Use cases (Optional)

If this PR introduces a new feature, it is better to list some use cases here and update the documentation.

Checklist

Before PR:

  • Pre-commit or other linting tools are used to fix the potential lint issues.
  • Bug fixes are fully covered by unit tests, the case that causes the bug should be added in the unit tests.
  • The modification is covered by complete unit tests. If not, please add more unit test to ensure the correctness.
  • The documentation has been modified accordingly, like docstring or example tutorials.

After PR:

  • If the modification has potential influence on downstream or other related projects, this PR should be tested with those projects.
  • CLA has been signed and all committers have signed the CLA in this PR.

Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.

Comments suppressed due to low confidence (1)

opencompass/datasets/subjective/arena_hard.py:149

  • Removing sorted() now returns keys in insertion order, which may differ from the previous behavior. Ensure that this change aligns with the intended order for win rate calculation.
names = list(elo_ratings.keys())

Copy link
Collaborator

@acylam acylam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might be more robust to join scores to the stats dataframe on model_name, but this will do for now.

@tonysy
Copy link
Collaborator

tonysy commented Apr 10, 2025

Agree with Junyao's comments, please consider join the scores to stats. @bittersweet1999

@MaiziXiao MaiziXiao merged commit 3f50b1d into main Apr 11, 2025
10 checks passed
domonic18 pushed a commit to domonic18/opencompass that referenced this pull request Apr 14, 2025
* 'main' of https://github.com/domonic18/opencompass:
  [Feature] LLM Judge sanity check (open-compass#2012)
  [Fix] fix order bug Update arena_hard.py (open-compass#2015)
  [Fix] Fix compare error when k is list in base_evaluator (open-compass#2010)
stephen-nju pushed a commit to stephen-nju/opencompass that referenced this pull request May 14, 2025
@tonysy tonysy deleted the bittersweet1999-patch-2 branch May 16, 2025 04:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants