Skip to content

[ci] Fix baseline score #1996

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 2, 2025

Conversation

zhulinJulia24
Copy link
Collaborator

Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.

Motivation

Please describe the motivation of this PR and the goal you want to achieve through this PR.

Modification

Please briefly describe what modification is made in this PR.

BC-breaking (Optional)

Does the modification introduce changes that break the backward compatibility of the downstream repositories?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.

Use cases (Optional)

If this PR introduces a new feature, it is better to list some use cases here and update the documentation.

Checklist

Before PR:

  • Pre-commit or other linting tools are used to fix the potential lint issues.
  • Bug fixes are fully covered by unit tests, the case that causes the bug should be added in the unit tests.
  • The modification is covered by complete unit tests. If not, please add more unit test to ensure the correctness.
  • The documentation has been modified accordingly, like docstring or example tutorials.

After PR:

  • If the modification has potential influence on downstream or other related projects, this PR should be tested with those projects.
  • CLA has been signed and all committers have signed the CLA in this PR.

Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This pull request updates CI testing workflows and baseline score configurations. The changes include:

  • Updating the pip installation command in the pr-run-test workflow to install the "full" extra.
  • Modifying the daily-run-test workflow to install updated dependencies including replacing torch versions and combining extra installations.
  • Renaming baseline score keys in the oc_score_baseline_fullbench YAML file from *_naive_average to *_accuracy.

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
.github/workflows/pr-run-test.yml Updated pip install options to use the "full" extra installation.
.github/workflows/daily-run-test.yml Modified dependency installation steps and updated torch versions.
.github/scripts/oc_score_baseline_fullbench.yaml Renamed baseline score keys for consistency in score reporting.
Comments suppressed due to low confidence (3)

.github/workflows/pr-run-test.yml:48

  • [nitpick] Consider verifying that the '[full]' extra installs all required components without causing dependency conflicts within the CI environment.
python3 -m pip install -e "[full]" --cache-dir ${{env.PIP_CACHE_PATH}}

.github/workflows/daily-run-test.yml:160

  • [nitpick] Review whether both 'opencompass[full]' and the subsequent 'opencompass[api]' installations are necessary, as there might be overlapping dependencies between the two extras.
pip install opencompass[full] --cache-dir ${{env.PIP_CACHE_PATH}}

.github/scripts/oc_score_baseline_fullbench.yaml:27

  • [nitpick] Ensure that all tools and downstream processes expecting the old '_naive_average' keys are updated to work with the new '_accuracy' key naming convention.
mmlu-other_accuracy: 72.6

Copy link
Collaborator

@MaiziXiao MaiziXiao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MaiziXiao MaiziXiao merged commit 97236c8 into open-compass:main Apr 2, 2025
8 checks passed
stephen-nju pushed a commit to stephen-nju/opencompass that referenced this pull request May 14, 2025
* update

* update

* update

* update
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants