Add support for generating placement with raw data #93
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/hold refactoring to fix code smells |
willkutler
force-pushed
the
multiple-clusters
branch
3 times, most recently
from
9f561ec to
152622e
Compare
|
/unhold |
dhaiducek
requested changes
Jan 30, 2023
mprahl
reviewed
Jan 30, 2023
mprahl
reviewed
Jan 30, 2023
mprahl
reviewed
Jan 31, 2023
mprahl
reviewed
Jan 31, 2023
mprahl
reviewed
Jan 31, 2023
mprahl
reviewed
Jan 31, 2023
mprahl
reviewed
Jan 31, 2023
|
@mprahl second round of review changes are in the latest commit |
mprahl
reviewed
Jan 31, 2023
mprahl
reviewed
Jan 31, 2023
mprahl
reviewed
Jan 31, 2023
|
@mprahl new review is done |
mprahl
reviewed
Feb 1, 2023
mprahl
reviewed
Feb 1, 2023
mprahl
reviewed
Feb 1, 2023
mprahl
reviewed
Feb 6, 2023
|
@willkutler this looks great. Just fix that one typo and squash your commits. I'll approve it afterwards. |
Placements can now be generated by nesting a full labelSelector or clusterSelector YAML under the `placement` key, in addition to the legacy method of listing key/value pairs under `placement`. This allows users to specify multiple clusters in the values array of a placement or placementRule, and to use matchLabels instead of matchExpressions (only supported by placement). Signed-off-by: Will Kutler <[email protected]>
willkutler
force-pushed
the
multiple-clusters
branch
from
77e3c2f to
9c30c36
Compare
|
Kudos, SonarCloud Quality Gate passed! |
|
@mprahl @dhaiducek I think this should be good to go |
mprahl
approved these changes
Feb 10, 2023
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mprahl, willkutler The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Placements can now be generated by nesting a full labelSelector or clusterSelector YAML under the
placementkey, in addition to the legacy method of listing key/value pairs underplacement. This allows users to specify multiple clusters in the values array of a placement or placementRule, and to use matchLabels instead of matchExpressions (only supported by placement).Signed-off-by: Will Kutler [email protected]