Skip to content

Conversation

@dhaiducek
Copy link
Member

Since the loop is technically working, it doesn't short-circuit Make.

Since the loop is technically working, it doesn't
short-circuit Make.

Signed-off-by: Dale Haiducek <[email protected]>
@openshift-ci openshift-ci bot requested review from gparvin and mprahl September 20, 2024 14:04
@dhaiducek dhaiducek changed the title Short-circuit-build Exit loop on build errors Sep 20, 2024
@openshift-ci
Copy link

openshift-ci bot commented Sep 20, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dhaiducek, mprahl

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants