Skip to content

Conversation

@dhaiducek
Copy link
Member

  • Fix severity set at the manifest level
  • Fix setting manifest overrides correctly
    • Since the manifest configuration wasn't being set when consolidateManifests was true, it wasn't being propagated to things like expanded policies and policy template manifests provided directly. This fixes it to set manifest configurations and then compare manifest and policy configurations to make sure they match when consolidateManifests is true.

ref: https://issues.redhat.com/browse/ACM-9131

@dhaiducek
Copy link
Member Author

Didn't account for Placement changes in main. Updating.

Since the manifest configuration wasn't being set
when consolidateManifests was true, it wasn't
being propagated to things like expanded policies
and policy template manifests provided directly.
This fixes it to set manifest configurations and
then compare manifest and policy configurations
to make sure they match when consolidateManifests
is true.

ref: https://issues.redhat.com/browse/ACM-9131
Signed-off-by: Dale Haiducek <[email protected]>
@dhaiducek dhaiducek force-pushed the 9132-manifest-config branch from e1f6be8 to 6f98d4f Compare December 18, 2023 19:29
@dhaiducek
Copy link
Member Author

/cherry-pick v1.12

@openshift-cherrypick-robot

@dhaiducek: once the present PR merges, I will cherry-pick it on top of v1.12 in a new PR and assign it to you.

In response to this:

/cherry-pick v1.12

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci
Copy link

openshift-ci bot commented Dec 18, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dhaiducek, mprahl

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-cherrypick-robot

@dhaiducek: new pull request created: #138

In response to this:

/cherry-pick v1.12

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants