Fix ExtraDependencies for ConfigPolicy manifests #126
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a `ConfigurationPolicy` manifest was provided directly, `extraDependencies` was being set at the `objectDefinition` level rather than the `policy-templates` level. ref: https://issues.redhat.com/browse/ACM-7353 Signed-off-by: Dale Haiducek <[email protected]>
dhaiducek
force-pushed
the
7353-extradeps
branch
from
d6a2169 to
d4c05ef
Compare
mprahl
approved these changes
Sep 7, 2023
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dhaiducek, mprahl The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
JustinKuli
reviewed
Sep 7, 2023
| // Only set dependency options if it's an OCM policy | ||
| if isOcmPolicy { | ||
| setTemplateOptions(manifest, ignorePending, extraDeps) | ||
| setTemplateOptions(policyTemplate, ignorePending, extraDeps) |
There was a problem hiding this comment.
So, it was a one word change? Awesome! 😆
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a
ConfigurationPolicymanifest was provided directly,extraDependencieswas being set at theobjectDefinitionlevel rather than thepolicy-templateslevel.ref: https://issues.redhat.com/browse/ACM-7353