improvement: use struct spec to avoid double % in struct inspect
#613
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
currently, inspecting an `OpenApiSpex.Schema` looks like this:
`%OpenApiSpex.Schema%{type: :object}`
with the new change, it looks like this:
`%OpenApiSpex.Schema{type: :object}`
which allows copy/pasting the struct
|
I hit this the other day, whew. |
zorbash
reviewed
Jul 2, 2024
zorbash
approved these changes
Jul 2, 2024
Contributor
Author
|
Getting killed a bit on the backwards compatibility here 😆 Do we need to go all the way back to 1.13? If so I'll have to come back to this later when I get a chance and conditionally use the things I'm using or inline the implementation from elixir I'm calling into. |
Collaborator
|
@zachdaniel No need to go back that far. I've updated the support matrix to drop < elixir 1.14 and OTP 22. |
nathanalderson
pushed a commit
to Tango-Tango/open_api_spex
that referenced
this pull request
Dec 20, 2024
…pen-api-spex#613) * improvement: use struct spec to avoid double `%` in struct inspect currently, inspecting an `OpenApiSpex.Schema` looks like this: `%OpenApiSpex.Schema%{type: :object}` with the new change, it looks like this: `%OpenApiSpex.Schema{type: :object}` which allows copy/pasting the struct
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
currently, inspecting an
OpenApiSpex.Schemalooks like this:%OpenApiSpex.Schema%{type: :object}with the new change, it looks like this:
%OpenApiSpex.Schema{type: :object}which allows copy/pasting the struct