Force to upgrade typing-extensions to a version above 4.0.0. #1873
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jay Zhang <[email protected]>
hwangdeyu
reviewed
Mar 2, 2022
| @@ -62,6 +62,8 @@ steps: | |||
| # onnx-weekly won't satisfy onnx requirement so uninstallation must happen here | |||
| pip uninstall -y onnx | |||
| pip install --index-url https://test.pypi.org/simple/ ${PIP_ONNX_NAME:-onnx} | |||
| pip uninstall typing-extensions | |||
There was a problem hiding this comment.
I guess it's related to onnx-weekly-1.10.1.dev20210830,
The latest one is 1.11.0.dev20220228, but it will install fail.
hwangdeyu
approved these changes
Mar 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For onnx-weekly CI job, upgrade the typing-extensions to a version above 4.0.0 to avoid unexpected crash on opset 15.
Signed-off-by: Jay Zhang [email protected]