Skip to content

cmake error for zdnn build[NNPA] #3262

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

cmake error for zdnn build[NNPA] #3262

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/Accelerators/NNPA/zdnn.cmake
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ function(setup_zdnn version)
BUILD_COMMAND sh -c "export MAKEFLAGS=--no-print-directory && \
make -q -C zdnn lib/libzdnn.so && true || \
(MAKEFLAGS=--no-print-directory \
make -j$(nproc) -C zdnn lib/libzdnn.so && \
make -C zdnn lib/libzdnn.so && \
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we all have used this when building onnx-mlir for NNPA, and our jenkins uses this also and haven't seen this error. I wonder under which circumstance you got this, perhaps, the local environment is different.

Can you confirm if your machine has nproc program? $(nproc) is to invoke nproc.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My machine has nproc program. It returns 106 inside or outside of the container. This issue is not new to me, and is not a persistent issue. Previously, when this issue happened, I just do not use ninja. I just don't understand why.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because the cmake files are meant to generate make rules not ninja rules which interpret $ sign differently. Slow down everyone just to make it work for ninja doesn't seem very productive.

For this particular case, if you want it to work for both make and ninja, you can do

diff --git a/src/Accelerators/NNPA/zdnn.cmake b/src/Accelerators/NNPA/zdnn.cmake
index ff7a280c..4d45f8f0 100644
--- a/src/Accelerators/NNPA/zdnn.cmake
+++ b/src/Accelerators/NNPA/zdnn.cmake
@@ -12,6 +12,14 @@ function(setup_zdnn version)
   set(ZDNN_OBJDIR     ${ZDNN_TOPDIR}/zdnn/obj)
   set(ZDNN_LIBDIR     ${ZDNN_TOPDIR}/zdnn/lib)

+  # ninja cannot handle $(nproc) in BUILD_COMMAND due to the $ sign
+  # so set a cmake variable ZDNN_NPROC
+  execute_process(
+    COMMAND nproc
+    OUTPUT_VARIABLE ZDNN_NPROC
+    OUTPUT_STRIP_TRAILING_WHITESPACE
+  )
+
   # Only build libzdnn on s390x
   if (${CMAKE_SYSTEM_PROCESSOR} STREQUAL "s390x")
     ExternalProject_Add(zdnn
@@ -38,7 +46,7 @@ function(setup_zdnn version)
       BUILD_COMMAND sh -c "export MAKEFLAGS=--no-print-directory && \
                          make -q -C zdnn lib/libzdnn.so && true || \
                          (MAKEFLAGS=--no-print-directory \
-                          make -j$(nproc) -C zdnn lib/libzdnn.so && \
+                          make -j${ZDNN_NPROC} -C zdnn lib/libzdnn.so && \
                           ar -rc ${ZDNN_LIBDIR}/libzdnn.a ${ZDNN_OBJDIR}/*.o)"

       INSTALL_COMMAND ""

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay. I thought that ninja is used in onnx-mlir by default. That's in the document.

ar -rc ${ZDNN_LIBDIR}/libzdnn.a ${ZDNN_OBJDIR}/*.o)"

INSTALL_COMMAND ""
Expand Down
Loading