Skip to content

Conversation

jorickert
Copy link
Collaborator

@jorickert jorickert commented Nov 21, 2024

Without this PR, the location of the Add/Mul will be incorrectly fused with the location of the constant.

Copy link
Collaborator

@tungld tungld left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@flemairen6
Copy link
Collaborator

@jenkins-droid test this please

Copy link
Collaborator

@AlexandreEichenberger AlexandreEichenberger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for adding a lit test, very thorough.

@jorickert
Copy link
Collaborator Author

@AlexandreEichenberger Could you take a look at the CI please? It seems to be stuck.
I think I do not have merge rights either, so someone would need to do this for me

@tungld
Copy link
Collaborator

tungld commented Nov 25, 2024

@jorickert The Jenkins machines are under maintenance and they are expected to be back soon this week. We will merge this PR and others as soon as the machines are available.

@AlexandreEichenberger
Copy link
Collaborator

@jenkins-droid test this please

@jorickert
Copy link
Collaborator Author

@tungld Are the jenkins runners working again? The status is still Expected — Waiting for status to be reported

@jorickert jorickert force-pushed the jrickert.upstream.commutative_loc branch from a76f70c to a3c0e2f Compare December 3, 2024 17:52
@jenkins-droid
Copy link
Collaborator

Can one of the admins verify this patch?

@tungld
Copy link
Collaborator

tungld commented Dec 4, 2024

@jenkins-droid test this please

@tungld tungld merged commit bac09ee into onnx:main Dec 4, 2024
7 checks passed
@jenkins-droid
Copy link
Collaborator

Jenkins Linux amd64 Build #16036 [push] Do not fuse locations wh... started at 20:43

@jenkins-droid
Copy link
Collaborator

Jenkins Linux s390x Build #16038 [push] Do not fuse locations wh... started at 21:43

@jenkins-droid
Copy link
Collaborator

Jenkins Linux ppc64le Build #15065 [push] Do not fuse locations wh... started at 21:58

@tungld
Copy link
Collaborator

tungld commented Dec 4, 2024

@tungld Are the jenkins runners working again? The status is still Expected — Waiting for status to be reported

Merged. Thanks for your contribution @jorickert!

@jenkins-droid
Copy link
Collaborator

Jenkins Linux amd64 Build #16036 [push] Do not fuse locations wh... passed after 1 hr 25 min

@jenkins-droid
Copy link
Collaborator

Jenkins Linux s390x Build #16038 [push] Do not fuse locations wh... passed after 1 hr 33 min

@jenkins-droid
Copy link
Collaborator

Jenkins Linux ppc64le Build #15065 [push] Do not fuse locations wh... aborted after 2 hr 7 min

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants