-
Notifications
You must be signed in to change notification settings - Fork 366
Do not fuse locations when normalizing constants for Add and Mul #3016
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks!
@jenkins-droid test this please |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for adding a lit test, very thorough.
@AlexandreEichenberger Could you take a look at the CI please? It seems to be stuck. |
@jorickert The Jenkins machines are under maintenance and they are expected to be back soon this week. We will merge this PR and others as soon as the machines are available. |
@jenkins-droid test this please |
@tungld Are the jenkins runners working again? The status is still |
Signed-off-by: Rickert, Jonas <[email protected]>
a76f70c
to
a3c0e2f
Compare
Can one of the admins verify this patch? |
@jenkins-droid test this please |
Jenkins Linux amd64 Build #16036 [push] Do not fuse locations wh... started at 20:43 |
Jenkins Linux s390x Build #16038 [push] Do not fuse locations wh... started at 21:43 |
Jenkins Linux ppc64le Build #15065 [push] Do not fuse locations wh... started at 21:58 |
Merged. Thanks for your contribution @jorickert! |
Jenkins Linux amd64 Build #16036 [push] Do not fuse locations wh... passed after 1 hr 25 min |
Jenkins Linux s390x Build #16038 [push] Do not fuse locations wh... passed after 1 hr 33 min |
Jenkins Linux ppc64le Build #15065 [push] Do not fuse locations wh... aborted after 2 hr 7 min |
Without this PR, the location of the Add/Mul will be incorrectly fused with the location of the constant.