Feature/add sessions to welcome #2527
Conversation
fix navigation of commands
create common getBorder function
move quick commands to the top of the welcome screen fix getBorder function to return default border of same size
re-arrange buttons for initial positioning
add icon to sessions list
fix accidentally triggered session restoration
|
Wow, that looks amazing! 👏 |
Codecov Report
@@ Coverage Diff @@
## master #2527 +/- ##
==========================================
+ Coverage 44.43% 44.51% +0.08%
==========================================
Files 351 351
Lines 14260 14302 +42
Branches 1862 1865 +3
==========================================
+ Hits 6336 6367 +31
- Misses 7697 7709 +12
+ Partials 227 226 -1
Continue to review full report at Codecov.
|
akinsho
force-pushed
the
feature/add-sessions-to-welcome
branch
from
62e8c10 to
207c42a
Compare
add snapshot and update tests
| </Column> | ||
| <Column alignment="flex-start"> | ||
| <SubtitleText>{`v${this.state.version}`}</SubtitleText> | ||
| {version && <SubtitleText>{`v${version}`}</SubtitleText>} |
There was a problem hiding this comment.
this change doesnt prevent the whole welcome layer from rendering if there is an issue with the getMetadata function not sure how it could fail but I don't think anything other than a full editor/app crash should prevent the initial welcome page from rendering
|
Functionally, loading sessions works great! I like the redesign too, but a few points:
Image for reference:
|
|
@CrossR thanks for having a look much appreciated 👍 re. the heading sizes I can increase those a bit for legibility |
seperated selectedItem selected styles into css block add margin to icon styles
|
@CrossR just tweaked the styles to reduce the overall size of the box, and increase the size of the headers, can you give it a try and let me know if its improved, locally the change is less obvious, also if the text is still to small can you see if tweaking you |
| }, | ||
| openFile: { command: "oni.editor.newFile" }, | ||
| openWorkspaceFolder: { command: "workspace.openFolder" }, | ||
| commandPalette: { command: "quickOpen.show" }, |
There was a problem hiding this comment.
This is called commandPalette but opens "quickOpen.show", instead of "commands.show".
| openFile: { command: "oni.editor.newFile" }, | ||
| openWorkspaceFolder: { command: "workspace.openFolder" }, | ||
| commandPalette: { command: "quickOpen.show" }, | ||
| commandline: { command: "executeVimCommand" }, |
There was a problem hiding this comment.
"executeVimCommand" doesn't exist, "editor.executeVimCommand" does, but is used to execute a command, not show the cmdline bar which I assume this was intended for.
| openTutor: { command: "oni.tutor.open" }, | ||
| openDocs: { command: "oni.docs.open" }, | ||
| openConfig: { command: "oni.config.openUserConfig" }, | ||
| openThemes: { command: "oni.themes.open" }, |
There was a problem hiding this comment.
"oni.themes.open" doesn't exist, I assume this should instead be "oni.themes.choose".
|
(I realise the things I'm commenting on are just formatting changes, but just documenting it!) |
|
@CrossR thanks for checking those I'll merge this and then open a smaller pr to fix up the other bits 👍 |
3 participants
Based off of #2522 (that should go in first) this PR adds a section with the available sessions to the welcome screen as well as the ability to restore a session.
This PR also has an updated welcome screen design (I begged a colleague who is a UI designer for some ideas for this hopefully we didn't got in the wrong direction)