Skip to content
This repository was archived by the owner on Apr 1, 2020. It is now read-only.

Conversation

CrossR
Copy link
Member

@CrossR CrossR commented Jul 26, 2018

Looks like the building of the CLI script was removed at some point, which meant the CLI scripts weren't working if the user didn't explicitly call yarn run build:cli.

Should we do a bit of a shuffle with the package.json to rename some of the scripts so we can use run-p more?

@codecov
Copy link

codecov bot commented Jul 26, 2018

Codecov Report

Merging #2463 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2463   +/-   ##
=======================================
  Coverage   43.44%   43.44%           
=======================================
  Files         341      341           
  Lines       13464    13464           
  Branches     1769     1769           
=======================================
  Hits         5850     5850           
  Misses       7337     7337           
  Partials      277      277

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e2c3fef...09bda33. Read the comment docs.

@bryphe
Copy link
Member

bryphe commented Jul 27, 2018

Thanks for catching this, @CrossR ! Looks good to me 😄

Should we do a bit of a shuffle with the package.json to rename some of the scripts so we can use run-p more?

Sure, that would make sense.

@CrossR CrossR merged commit b921412 into onivim:master Jul 27, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants