Skip to content
This repository was archived by the owner on Apr 1, 2020. It is now read-only.

Conversation

akinsho
Copy link
Member

@akinsho akinsho commented Jul 24, 2018

Currently the signature help remains open if a user scrolls the buffer mid input, causing it to follow the cursor to the wrong position.

This change removes the cursor moved auditTime and adds a scroll observable which closes the signature help on scroll

hopefully fixes #2237

@akinsho akinsho changed the title Remove cursor moved debounce add scroll observable Bugfix/ Close signature help on scroll Jul 24, 2018
@akinsho akinsho changed the title Bugfix/ Close signature help on scroll [WIP] Bugfix/ Close signature help on scroll Jul 24, 2018
@akinsho akinsho changed the title [WIP] Bugfix/ Close signature help on scroll Bugfix/ Close signature help on scroll Jul 24, 2018
@codecov
Copy link

codecov bot commented Jul 24, 2018

Codecov Report

Merging #2454 into master will decrease coverage by <.01%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2454      +/-   ##
==========================================
- Coverage   42.62%   42.62%   -0.01%     
==========================================
  Files         332      332              
  Lines       13212    13213       +1     
  Branches     1736     1736              
==========================================
  Hits         5632     5632              
- Misses       7302     7303       +1     
  Partials      278      278
Impacted Files Coverage Δ
browser/src/Services/Language/SignatureHelp.ts 20.51% <0%> (ø) ⬆️
...ces/Language/addInsertModeLanguageFunctionality.ts 36.36% <0%> (ø) ⬆️
browser/src/Editor/NeovimEditor/NeovimEditor.tsx 9.36% <0%> (-0.02%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4ce7b50...f0e55cd. Read the comment docs.

Copy link
Member

@bryphe bryphe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Thanks @akin909 👍

@akinsho akinsho merged commit 97f643e into onivim:master Jul 26, 2018
@akinsho akinsho deleted the feature/close-signature-help-correctly branch July 26, 2018 06:20
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Signature help doesn't always disappear

2 participants