Skip to content

[Task]: Add Aria labels to list items on dataset pages #561

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 1, 2024
Merged

[Task]: Add Aria labels to list items on dataset pages #561

merged 1 commit into from
May 1, 2024

Conversation

aleeexgreeen
Copy link
Contributor

What this PR accomplishes

  • Adds accessible name to resource-item-div link on dataset pages
  • Removes additional links in resource-item-div, leading to resource page

Issue(s) addressed

  • DATA-1479

What needs review

  • Resource item div on dataset page has an aria-label
  • For non-admin/non-logged in users, the resource-item-div should have only one link (the anchor-div)
  • For admin/logged in users, the resource-item-div will have the title, explore button, and edit button as links.

@aleeexgreeen aleeexgreeen changed the title [Task}: Add Aria labels to list items on dataset pages [Task]: Add Aria labels to list items on dataset pages Apr 29, 2024
KobikahChandran
KobikahChandran approved these changes May 1, 2024
View reviewed changes
Copy link
Collaborator

@KobikahChandran KobikahChandran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No concerns!

@KobikahChandran KobikahChandran merged commit 7c5394c into develop May 1, 2024
@KobikahChandran KobikahChandran deleted the DATA-1479 branch May 1, 2024 17:50
aimalkhan pushed a commit that referenced this pull request Oct 5, 2024
@aleeexgreeen @aimalkhan
accessible name for resource item div (#561)
4cf661e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KobikahChandran KobikahChandran KobikahChandran approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aleeexgreeen @KobikahChandran