Skip to content

Conversation

KobikahChandran
Copy link
Collaborator

What this PR accomplishes

Changes design of tabs on Dataset's, Ministry's, Group's and Admin's pages to classic tabs

Issue(s) addressed

DATA-1045

What needs review

  • Correct colours when tabs are active, non-active, interactive state
  • No gap between tabs and navigation tab line
  • Tabs correctly working
  • Views match across different devices and match Figma design

Copy link
Contributor

@aleeexgreeen aleeexgreeen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good so far! I've suggested some changes to increase responsive design

Copy link
Contributor

@aleeexgreeen aleeexgreeen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good :)!

@aleeexgreeen aleeexgreeen merged commit 96da321 into develop Feb 14, 2024
@aleeexgreeen aleeexgreeen deleted the DATA-1045_classic_tabs_v2 branch February 14, 2024 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants