caching of application icons

[Rairosu]

Currently application icons are not being cached, which results in onagre microfreezing everytime I try to search for an application.

If there is no specific reason against caching those icons, I would like those icons to be cached.

[oknozor]

There is a first query to build the icon index then its cached on every subsequent request:

onagre/src/icons/mod.rs

Line 85 in 543f1fe

.with_cache()

That said, in the current implementation, the cache still need to be loaded on every start.

We could store this in db to make it available on next launch.
Note that it has the potential to be out of sync if the user uninstall or add new desktop entries, change their theme etc.

A correct implementation should greedily load the cache on start, then fetch the up to date icon index in the background and replace the current cache with actual runtime values.

PRs welcome :)

[Rairosu]

I looked at this line already and my point is that it is missing for the else case, but i didn't want to submit a pr for one line of code. The idea of storing it in the db sounds nice, as it still stutters on startup a bit, even with caching all icons, maybe i get around to doing a pr for that ^^

[shotor]

There is a first query to build the icon index then its cached on every subsequent request:

onagre/src/icons/mod.rs

Line 85 in 543f1fe
.with_cache()

That said, in the current implementation, the cache still need to be loaded on every start.

We could store this in db to make it available on next launch. Note that it has the potential to be out of sync if the user uninstall or add new desktop entries, change their theme etc.

A correct implementation should greedily load the cache on start, then fetch the up to date icon index in the background and replace the current cache with actual runtime values.

PRs welcome :)

I'd be up to implement this. I like icons but launcher is unusable for me with icons due to lag.

Suggestions for db index? fs, sqlite, background service, something else? How would we handle app exiting while cache update running?

[oknozor]

Hello @shotor, we are already using redb for cache operation (desktop entry, plugin history). It should be easy to adapt the current DB to cache icon aswell.

Also I don't want any background process to run in the wild, caching operation should be done at onagre runtime.

Note that there is work in progress PR updating onagre to iced 13, you should probably use this branch as base as it will merged soon.

Also keep in mind that icon cache resolution is tied to the user defined theme, the unique identifier for an icon should be a combination of icon name + icon theme