test(contracts): add Quorum library tests #923
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It's unclear why bindings are changing so much for the reqgistries. The Trying swtiching to using Acutally will do that in separate PR and rebase this one Let's merge this #924 and then I'll rebase and we'll see if there are bindings changes |
kevinhalliday
commented
Apr 23, 2024
| } | ||
|
|
||
| if (_isValidSig(sig, digest)) votedPower += validators[sig.validatorAddr]; |
There was a problem hiding this comment.
Decided to error here instead of just passing. I think that's more appropriate. Only valid signatures can be submitted. If any invalid signatures are, we revert.
kevinhalliday
force-pushed
the
kh/quorum-tests
branch
2 times, most recently
from
639431b to
6bcd7c5
Compare
ttarsi
approved these changes
Apr 23, 2024
kevinhalliday
force-pushed
the
kh/quorum-tests
branch
from
6bcd7c5 to
8d431da
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add quorum library tests.
task: https://app.asana.com/0/1206208509925075/1207144685868132