feat: make zarr dependency optional #280
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
looks compelling to me! curious to hear what others think about this direction |
|
@d-v-b can you approve the workflow so I can see if the tests are working on ci? |
|
oops sorry... weird version got in there. one more time please? 😬 |
dstansby
reviewed
Sep 15, 2025
This was referenced Sep 15, 2025
tlambert03
force-pushed
the
zarr-optional
branch
from
59e622c to
5706098
Compare
|
k, this is working again, and has pinned itself to the new main on pydantic-zarr, and fixes all the issues that came with zarr-developers/pydantic-zarr#115 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
bare minimum required to make zarr dependency optional .
Not necessarily saying this is the best/cleanest way to do this, but it at least marks all the places where imports were made just for the sake of type hinting.
(closes #161)
testing this without zarr (i.e. running
pip uninstall zarr && pytestand having it work) depends on https://github.com/tlambert03/pydantic-zarr/tree/drop-zarr (zarr-developers/pydantic-zarr#112)