refactor(architecture): extract ProjectManager class from mainWindow #1379
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Major architectural refactoring to improve code organization: - **Extracted ProjectManager class** from mainWindow.py (~300 lines) - Moved project lifecycle methods: loadProject, closeProject, saveDatas - Moved timer management: saveTimer, saveTimerNoChanges - Moved data management: loadEmptyDatas, loadDatas - Moved unsaved changes handling: handleUnsavedChanges - Updated all calling code to use projectManager interface - `manuskript/projectManager.py` - Project lifecycle management - `manuskript/tests/test_projectManager.py` - Basic ProjectManager tests (2 tests) - `manuskript/tests/test_projectManager_timer.py` - Comprehensive timer tests (9 tests) - `manuskript/mainWindow.py` - Removed ~300 lines, added projectManager integration - `manuskript/ui/welcome.py` - Updated to use projectManager interface - `manuskript/settingsWindow.py` - Updated timer access via projectManager - `manuskript/tests/conftest.py` - Updated test fixtures for new interface - Added 11 new unit tests total covering ProjectManager functionality - Comprehensive timer testing with proper Qt mocking - All existing tests continue to pass (50 total tests) - Tests validate both positive and negative scenarios - Reduced mainWindow.py complexity (2000+ -> 1700 lines) - Improved separation of concerns - Better testability with isolated components - Foundation for further architectural improvements
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Major architectural refactoring to improve code organization:
manuskript/projectManager.py- Project lifecycle managementmanuskript/tests/test_projectManager.py- Basic ProjectManager tests (2 tests)manuskript/tests/test_projectManager_timer.py- Comprehensive timer tests (9 tests)manuskript/mainWindow.py- Removed ~300 lines, added projectManager integrationmanuskript/ui/welcome.py- Updated to use projectManager interfacemanuskript/settingsWindow.py- Updated timer access via projectManagermanuskript/tests/conftest.py- Updated test fixtures for new interface