chg: set position of sidebar overlay to 'fixed' #322
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This pull request includes a small change to the
src/site/styles/digital-garden-base.scss
file. The change updates theposition
property of.fullpage-overlay
fromabsolute
tofixed
to ensure the overlay remains fixed relative to the viewport.What is the issue
When the filetree is opened, the full page overlay is in an 'absolute' position, whereas the sidebar position is 'fixed'. This creates a disconnect when a visitor performs the following actions:
Proposed solution
Consider changing the
position
property of the.fullpage-overaly
from 'absolute' to 'fixed'.Caveats
This disables the ability for the visitor to scroll through the page while the sidebar is opened. This seems like more reasonable behavior to me, but would like to discuss.