Fix edge cases in link creation #321
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes oleeskild#319 oleeskild#318 Add console output when dead links are detected
Text inside a codeblock that looked like a link "[[what|ever]]" was removed before Replaced the regex used to identify links with a manual search and replace loop Fixes oleeskild#317
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #317 #318 #319
Some minor fixes allow links to headings in the same document
[[#heading]]and links to documents with a & in the filename.A bigger rewrite replaces a regex with a manual loop, so we can identify codeblocks and ignore anything that looks like a link inside them. (the clean solution would be building something like an AST, but that is out of scope for me right now)
I had this code live on my page for a while and have not noticed any issues or weird behaviour.