refactor(separator): update component #449
Conversation
|
Thank you for following the naming conventions! 🙏 |
| validator: (value: string): boolean => { | ||
| if (!isValidOrientation(value)) | ||
| console.error(getInvalidOrientationError(String(value), SEPARATOR_NAME)) | ||
|
|
||
| return true | ||
| }, |
There was a problem hiding this comment.
I moved the prop validation from the component to the props itself. However, since the validator does not support a custom error message, I used console.error instead of using throw new Error.
Actually, there is no emits in that component. That's why I didn't use |
|
The reason for this is that because you use emits at the top, the transition to the bottom is not applied, the emits remain in the script if the user sends emits. |
Yes, I understand that. But that component doesn't accept any emits it's actually empty |
|
I'm torn on this one, you're right, they both work. |
|
shall we merge ? |
Yes, please! |
Description
Linked Issues
cc #358
Additional context