Fix removeListener Iteration

[aidant]

The current implementation of EventHandler#removeListener never iterates to index 0 in the state.

---

Example code to reproduce this issue:

const Octokit = require('@octokit/rest')
const Webhook = require('@octokit/webhooks')
const http = require('http')

const GITHUB_ORGANIZATION_NAME = ''
const GITHUB_ORGANIZATION_WEBHOOK_ID = 0
const GITHUB_ORGANIZATION_WEBHOOK_PATH = '/'
const GITHUB_ORGANIZATION_WEBHOOK_PORT= 8080
const GITHUB_ORGANIZATION_WEBHOOK_SECRET = ''
const GITHUB_PERSONAL_ACCESS_TOKEN = ''

const octokit = new Octokit({
  auth: GITHUB_PERSONAL_ACCESS_TOKEN
})

const webhook = new Webhook({
  path: GITHUB_ORGANIZATION_WEBHOOK_PATH,
  secret: GITHUB_ORGANIZATION_WEBHOOK_SECRET
})

const entrypoint = async () => {
  const listener = (event) => {
    webhook.removeListener('*', listener)
    console.log(`Received event: "${event.name}".`)
  }

  webhook.on('*', listener)

  await octokit.orgs.pingHook({
    org: GITHUB_ORGANIZATION_NAME,
    hook_id: GITHUB_ORGANIZATION_WEBHOOK_ID,
  })

  await octokit.orgs.pingHook({
    org: GITHUB_ORGANIZATION_NAME,
    hook_id: GITHUB_ORGANIZATION_WEBHOOK_ID,
  })
}

http.createServer(webhook.middleware)
  .listen(GITHUB_ORGANIZATION_WEBHOOK_PORT, () => entrypoint().catch(console.error))

Without the fix:

Received event: "ping".
Received event: "ping".

With the fix:

Received event: "ping".

[gr2m]

Wonderful pull request, thank you so much! I just have one little nitpick question

[gr2m]

Wow, good catch, thanks so much for investigating and sending a pull request, with tests 😻

[gr2m]

have you meant to call this variable removeListener? I think that would make the tests a little more clear!

[aidant]

I agree it does look cleaner to call it removeListener. I've updated the test with the new name.

[gr2m]

Perfect, thank you!

[octokitbot]

🎉 This PR is included in version 6.3.1 🎉

The release is available on:

• npm package (@latest dist-tag)
• GitHub release

Your semantic-release bot 📦🚀