Skip to content

Match routes that trigger notification using a regex #4

@gr2m

Description

@gr2m

With the implementation at #2, the following request would match

octokit.request('POST /repos/:owner/:repo/issues', options)

But if someone replaces the URL parameters before sending a request, it wouldn’t:

octokit.request('POST /repos/foo/bar/issues', options)

This should be an exception so I don’t think it’s a big problem right now, but it would be better if we would match both requests in future

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions