Add tests #6
Open
Add tests #6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Update base image to Ubuntu 22.04 * Enhance caching between build steps * Ensure correct Nginx image is used * Fix authentication issues on PRs * Re-enable cron schedule with updated 'sed' commands
There was a problem hiding this comment.
Pull Request Overview
This PR adds a full testing infrastructure to ensure only valid LanCache images are tagged as latest.
- Introduces
TESTING.mdwith a guide for PR, scheduled, and performance tests - Adds a scheduled build workflow to pre-validate releases (
test-scheduled-functionality.yml) - Implements PR functionality and performance test workflows (
test-pr-functionality.yml,performance-tests.yml)
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| TESTING.md | Adds detailed guide for PR, scheduled, and perf tests |
| .github/workflows/test-scheduled-functionality.yml | Defines 'Scheduled Build Functionality Tests' workflow |
| .github/workflows/test-pr-functionality.yml | Adds 'PR Functionality Tests' workflow |
| .github/workflows/performance-tests.yml | Implements 'Performance and Load Tests' workflow |
Comments suppressed due to low confidence (3)
.github/workflows/performance-tests.yml:215
- The
Cache Performance Teststep is mis-indented under the HTTP step, causing it to be treated as part of the shell script rather than a separate workflow step. Align the- nameand itsrun:block with the other steps understeps:to correct the YAML syntax.
- name: Cache Performance Test
.github/workflows/test-pr-functionality.yml:151
- [nitpick] The
test-content.txtfile is created but never used in subsequent steps. Consider removing this file or mounting it into the container if it's intended for the direct-download scenario.
echo "This is test content for cache validation" > test-content.txt
.github/workflows/test-pr-functionality.yml:128
- The
test_urlvariable is set for CDN scenarios but never used in the cache functionality test. Either reference it in your HTTP requests or remove the unused variable.
test_url="http://steamcontent.com/depot/test.bin"
* Replace wait-on-check-action with action-wait-for-check for better PR build handling * Enhance DNS testing by switching from nslookup to dig for accuracy * Simplify test scenarios and improve cache functionality checks * Update ARM64 testing setup and streamline container health checks * Revise test summary output for clarity and detail
* Replace action-wait-for-check with actions/checkout for improved build handling * Update IP addresses in test environment for better network configuration * Modify health checks and DNS testing to use specific IPs * Streamline ARM64 testing setup and ensure compatibility with updated configurations * Improve error handling and logging for container health checks
…ainer issues * Enhance TESTING.md with detailed debug steps and solutions for DNS resolution failures and container startup issues * Modify GitHub Actions workflow to improve health checks and logging for DNS container * Update health check commands and increase startup wait time for better reliability
…lution * Clarify root cause of DNS resolution failures in TESTING.md * Enhance debug steps for DNS container issues, including specific commands and configurations * Modify GitHub Actions workflow to check correct cache domains and improve logging for DNS tests * Ensure proper directory paths and configurations are referenced in health checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces two new GitHub Actions workflows to enhance automated testing for the project: one for performance and load testing, and another for PR functionality testing. These workflows aim to ensure robust performance, compatibility, and functionality across different scenarios and architectures.
Performance and Load Testing Workflow (
.github/workflows/performance-tests.yml)workflow_dispatchto conduct performance and load tests with configurable parameters such as test target, custom image tags, and load intensity.wrk.PR Functionality Testing Workflow (
.github/workflows/test-pr-functionality.yml)