-
Notifications
You must be signed in to change notification settings - Fork 177
Added source and type to the metadata object. Updated the log_* attributes and descriptions for consistency. #1483
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Paul Agbabian <[email protected]>
Signed-off-by: Paul Agbabian <[email protected]>
|
Yes, agreed - however as I read the descriptions for the log*_* attributes and the |
|
The Splunk extension has these within the
|
|
As I've been reviewing However, as with the Splunk extension (which mirrors Splunk default fields), there are other types of sources besides log files, and the We already have two forms of For example, Splunk has different There is a Etc. Therefore, whether redundant or not, IMO |
…d log_format to metadata and loggers. Added transmit_time to metadata. Deprecated version in loggers in favor of the added log_version. Signed-off-by: Paul Agbabian <[email protected]>
Signed-off-by: Paul Agbabian <[email protected]>
… metadata. Signed-off-by: Paul Agbabian <[email protected]>
Signed-off-by: Paul Agbabian <[email protected]>
Signed-off-by: Paul Agbabian <[email protected]>
Signed-off-by: Paul Agbabian <[email protected]>
…the original log schema, but not the format (as it was described before). Signed-off-by: Paul Agbabian <[email protected]>
… the description of log_version. Signed-off-by: Paul Agbabian <[email protected]>
Signed-off-by: Paul Agbabian <[email protected]>
…description effectively.
…ions of correlation_uid and uid. Signed-off-by: Paul Agbabian <[email protected]>
…ved the deprecation of logger.version. Signed-off-by: Paul Agbabian <[email protected]>
…ictionary. Tweaked some metadata log descriptions for source and type. Signed-off-by: Paul Agbabian <[email protected]>
Signed-off-by: Paul Agbabian <[email protected]>
Signed-off-by: Paul Agbabian <[email protected]>

Related Issue: #1487
Description of changes:
Currently OCSF events don't explicitly call out the source or type of the event, whether natively produced or mapped from another source. A classic approach to high level classificaiton of telemetry data, or experimental measurement data is to have standard
sourceandtypelabels. Althoughmetadatahas a generallabelsarray, it is more structured to standardize the names for these two dimensions of events.loggerandloggersare intended to indicate the chain of custody of events in a pipeline. There is a special case where the "source" of an event comes from a log.Splunk has
hostsourceandsourcetypefields that correspond to the physical origin of the event, (e.g. /var/log/messages) and its combined source and format (e.g. cisco_syslog, Apache access_combined). Given it is implicit that the format of an OCSF event is OCSF,typewithinmetadatais not a format but rather a classification (e.g. firewall traffic logs).These are optional attributes.
In the process of analyzing the gaps, I noticed that the
log_*attributes have evolved in an ambiguous way. Specifically it isn't clear whether the log in question is a source log or a consumer log (e.g. a SIEM). Thelog_versionwas an indirect format indicator but with no detail. Theloggerobject andloggersarray were not clearly distinguished from what is represented forlog_*inmetadata.Hence I modified the descriptions in light of new, explicit
log_sourceandlog_formatattributes, and updated the description oflog_versionwhich then entailed the deprecation ofversionfromloggersin favor oflog_versionto be consistent.