Skip to content

force chronyd start on helper before cert generation #181

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

schabrolles
Copy link
Contributor

Manually restart chronyd and not wait for trigger to be sure that time is right before creating openshift certificates.

@ppc64le-cloud-bot
Copy link
Contributor

ppc64le-cloud-bot commented Apr 12, 2023

@schabrolles: PR is not mergeable.

The PR state is: blocked

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ppc64le-cloud-bot ppc64le-cloud-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Apr 12, 2023
@schabrolles schabrolles force-pushed the force-chronyd-start-before-certificate-generation branch from 4f7ff1a to 166f5b6 Compare April 12, 2023 06:30
@schabrolles schabrolles force-pushed the force-chronyd-start-before-certificate-generation branch from 166f5b6 to 29b167b Compare June 25, 2023 20:01
@Prajyot-Parab
Copy link
Collaborator

@schabrolles please squash commits into a single commit, rest lgtm

@schabrolles
Copy link
Contributor Author

@Prajyot-Parab, It seems to be only one commit on my side.

image

@Prajyot-Parab
Copy link
Collaborator

Prajyot-Parab commented Jul 4, 2023

@Prajyot-Parab, It seems to be only one commit on my side.

image

@schabrolles you can do git fetch and rebase on your local it will show up, (as all 3 commits can be seen as part of your fork)

PS - those 2 commits from my end were meant to fix minor issue with this PR and that needs to squash with your 1 commit

@yussufsh
Copy link
Contributor

yussufsh commented Sep 5, 2023

@schabrolles You need to pull the latest upstream and then rebase your commit on top of that. See this link if you need more info.

Also, sign your commit. See the DCO failure above, click on Details link on how to.

@schabrolles schabrolles force-pushed the force-chronyd-start-before-certificate-generation branch from 6fe7e80 to f4192f7 Compare September 20, 2023 08:11
@schabrolles
Copy link
Contributor Author

@yussufsh is it good now ?

@yussufsh
Copy link
Contributor

@schabrolles schabrolles force-pushed the force-chronyd-start-before-certificate-generation branch from f4192f7 to 568300d Compare September 20, 2023 08:18
@schabrolles schabrolles force-pushed the force-chronyd-start-before-certificate-generation branch from 07c9537 to 604d9cb Compare September 20, 2023 08:20
Copy link
Contributor

@yussufsh yussufsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@ppc64le-cloud-bot ppc64le-cloud-bot added the lgtm Indicates that a PR is ready to be merged. label Sep 20, 2023
@ppc64le-cloud-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: schabrolles, yussufsh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ppc64le-cloud-bot ppc64le-cloud-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 20, 2023
@schabrolles
Copy link
Contributor Author

@yussufsh done

@yussufsh
Copy link
Contributor

@yussufsh done

Thanks for the efforts :)

@ppc64le-cloud-bot ppc64le-cloud-bot merged commit efb74c5 into ocp-power-automation:main Oct 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants