-
Notifications
You must be signed in to change notification settings - Fork 52
force chronyd start on helper before cert generation #181
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
force chronyd start on helper before cert generation #181
Conversation
@schabrolles: PR is not mergeable. The PR state is: blocked Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
4f7ff1a
to
166f5b6
Compare
166f5b6
to
29b167b
Compare
@schabrolles please squash commits into a single commit, rest lgtm |
@Prajyot-Parab, It seems to be only one commit on my side. ![]() |
@schabrolles you can do git fetch and rebase on your local it will show up, (as all 3 commits can be seen as part of your fork) PS - those 2 commits from my end were meant to fix minor issue with this PR and that needs to squash with your 1 commit |
@schabrolles You need to pull the latest upstream and then rebase your commit on top of that. See this link if you need more info. Also, sign your commit. See the DCO failure above, click on |
6fe7e80
to
f4192f7
Compare
@yussufsh is it good now ? |
Just this one needs to be fixed. https://github.com/ocp-power-automation/ocp4-playbooks/pull/181/files#r1243997842 |
f4192f7
to
568300d
Compare
Signed-off-by: Sebastien Chabrolles <[email protected]>
07c9537
to
604d9cb
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: schabrolles, yussufsh The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@yussufsh done |
Thanks for the efforts :) |
Manually restart chronyd and not wait for trigger to be sure that time is right before creating openshift certificates.