Skip to content

Conversation

johan0A
Copy link
Contributor

@johan0A johan0A commented Apr 22, 2025

This is my fix I use for: #8271

@ocornut
Copy link
Owner

ocornut commented Apr 26, 2025

I am tempted to accept it (maybe with VkShaderModule inputs instead? so if vkCreateShaderModule() ever adds flags that'd be in control of the user), but it seems like it would be a better general-purpose feature to make it easier to change shaders in the render loop.

@johan0A
Copy link
Contributor Author

johan0A commented Apr 26, 2025

Jus to clarify I dont think this really solves #8271 but it does offer a good workaround for it.

(maybe with VkShaderModule inputs instead? so if vkCreateShaderModule() ever adds flags that'd be in control of the user)

Or with a VkShaderModuleCreateInfo?

@olivier-gerard
Copy link

Just adding my 2 cents : having custom VkShaderModuleCreateInfo fields look nice has it hosts user flags.
Sharing VkShaderModule objects with main app is more complex as they shall be destroyed and responsibility of this may be unclear.

@ocornut
Copy link
Owner

ocornut commented Sep 26, 2025

I have reworked this to use VkShaderModuleCreateInfo and merged as 01686c6.
Thanks both for your input!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants