add ppopt(arg) and ppxopt(package,arg) when -use-ocamlfind #265
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
whitequark
reviewed
Dec 31, 2017
src/ocaml_specific.ml
Outdated
| if List.mem "ocaml" tags then begin | ||
| pflag tags "syntax" ~doc_param:"camlp4o" | ||
| (fun pkg -> S [A "-syntax"; A pkg]); | ||
| pflag tags "ppopt" ~doc_param:"camlp4-arg" |
There was a problem hiding this comment.
-pp is not just camlp4, isn't it? ocaml-m17n also uses -pp.
There was a problem hiding this comment.
I reused the name from the ocamlfind documentation, and it is just informative (there is no semantics on the doc_param). Yet your point is completely correct and I will change it to use pparg instead.
gasche
force-pushed
the
ppopt-ppxopt
branch
2 times, most recently
from
da0ec9d to
ed6a0d2
Compare
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a pull request to fix #45, #190. I haven't thought very hard about the feature, and this is a minimalist implementation, that only passes the options unchanged to
ocamlfind, and in particular is only available when-use-ocamlfindis used.